[router] Create routes without a menu item with the id and not alias#20117
Closed
laoneo wants to merge 2 commits intojoomla:stagingfrom
Closed
[router] Create routes without a menu item with the id and not alias#20117laoneo wants to merge 2 commits intojoomla:stagingfrom
laoneo wants to merge 2 commits intojoomla:stagingfrom
Conversation
Member
Author
|
Closing it in favor of #19280. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative for pull request #19280.
Summary of Changes
When there is no menu item for category/categories/article view in com_content and the option Remove IDs is enabled then a link like the following is created:
/index.php/en/component/content/article/article-en-gb?catid=8
This returns an error 404. This pr changes the url to contain the id instead of the alias like:
/index.php/en/component/content/article/1?catid=8
It is a break as it is ignoring the setting Remove IDs.
Testing Instructions
Expected result
The article is opened.
Actual result
A 404 is thrown.