Skip to content

[3.9] Add APCu session storage#19990

Closed
mbabker wants to merge 1 commit intojoomla:3.10-devfrom
mbabker:apcu-session
Closed

[3.9] Add APCu session storage#19990
mbabker wants to merge 1 commit intojoomla:3.10-devfrom
mbabker:apcu-session

Conversation

@mbabker
Copy link
Copy Markdown
Contributor

@mbabker mbabker commented Mar 25, 2018

Pull Request for Issue #19940

Summary of Changes

Add session storage backend supporting PHP's ext/apcu

Testing Instructions

Install patch, on a platform where APCu is installed and enabled try to use APCu as a session storage backend

@zero-24
Copy link
Copy Markdown
Contributor

zero-24 commented Mar 29, 2018

@f-hamel can you please test the patch provided by @mbabker ?

If you need help with that feel free to ask questions. As I personally don't have a server with APCu enabled.

You can find a documentations how you can test here in detail: https://docs.joomla.org/Testing_Joomla!_patches

The easiest way would be to download & install the latest nigthly build for Joomla 3.9:
https://developer.joomla.org/nightlies/Joomla_3.9.0-dev-Development-Full_Package.zip
Install the com_patchtester component:
https://github.com/joomla-extensions/patchtester/releases/tag/2.0.1
Refresh the data.
use the search bar to get to the PR ID: 19990 & hit apply patch.
Than you can try to use apcu as session storage as requested in your issue.
Please report any questions / issues or suggestions to this page so this can be discussed & adressed.

Please note that this only can get merged into the core & released if we have tests on this code proposal. Thanks 👍

@ghost
Copy link
Copy Markdown

ghost commented Mar 29, 2018

@zero-24 and @mbabker I'm sorry. I was little bit busy the last days.
So thanks for remembering and this good testing instruction.
I could apply the patch and test.

There was no unexpected behavior.
APCu Session storage is available and works fine.

@ghost
Copy link
Copy Markdown

ghost commented Mar 29, 2018

@f-hamel please mark your Test as successfully:

  • open Issue Tracker
  • Login with your github-Account
  • Click on blue "Test this"-Button above Authors-Picture
  • mark your Test as successfully
  • hit "submit test result"

@ghost
Copy link
Copy Markdown

ghost commented Mar 29, 2018

I have tested this item ✅ successfully on 68924ca


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19990.

@zero-24
Copy link
Copy Markdown
Contributor

zero-24 commented Mar 30, 2018

@mbabker can you update that branch to 3.9-dev so we keep drone happy.

I would like to move this RTC than given that the code bases on the framework and @f-hamel 's test on a live environment.

@zero-24
Copy link
Copy Markdown
Contributor

zero-24 commented Mar 30, 2018

Ah they just enabled the push button :)

@zero-24
Copy link
Copy Markdown
Contributor

zero-24 commented Mar 30, 2018

RTC. Thanks 👍


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19990.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 30, 2018
@zero-24 zero-24 added this to the Joomla 3.9.0 milestone Mar 30, 2018
@laoneo
Copy link
Copy Markdown
Member

laoneo commented Mar 31, 2018

Is this valid for 4.0 too? Or do we have there APCU from the framework package?

@mbabker
Copy link
Copy Markdown
Contributor Author

mbabker commented Mar 31, 2018 via email

@mbabker
Copy link
Copy Markdown
Contributor Author

mbabker commented May 12, 2018

Cherry picked into 3.9 via 51dc6e0

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants