Looks good to me. Can you do some update files as well please - I want to start gearing up for a 3.9 alpha 1 where you can upgrade to 4.0

There is an update file. Only the one for postgres is missing.

add in administrator/components/com_admin/sql/updates/postgresql/4.0.0-2018-03-05.sql
ALTER TABLE "#__modules" ALTER COLUMN "content" DROP NOT NULL;

but shouldn't work without #19707

p.s
unable to open pr on your branch

Thanks @alikon, added the script. Can you double check the changes in the joomla.sql of postgres? Are they ok?

I guess we are here fine.

#19707 apart yes

@laoneo its fine modules save success :)

You need to use Alter Column in the mysql change please otherwise the schema checker (https://github.com/joomla/joomla-cms/blob/4.0-dev/libraries/src/Schema/ChangeItem/MysqlChangeItem.php) won't pick it up

There is no Alter Column or do I miss something here?

OK I'm just being dumb. We also have support for change https://github.com/joomla/joomla-cms/blob/4.0-dev/libraries/src/Schema/ChangeItem/MysqlChangeItem.php#L168

But looks like currently it's only going to work for changing column types. Not for swapping things to not null. In fact the "kludge" for integer unsigned is going to trigger with TEXT NULL tho right? https://github.com/joomla/joomla-cms/blob/4.0-dev/libraries/src/Schema/ChangeItem/MysqlChangeItem.php#L170-L176

Isnt this the same as #17752 ??

This one here is a subset of it and solves one purpose to fix creating modules. #17752 does more and needs carefully be tested as there should basically be a test case for every change in the install scripts which got changed. #17752 is also not finished as the update scripts are missing.

Where do we stay here? I think it would be not bad when we release the next alpha to be able to create modules.

But looks like currently it's only going to work for changing column types. Not for swapping things to not null. In fact the "kludge" for integer unsigned is going to trigger with TEXT NULL tho right?

After PR and database fix, the modules table stayed the same.
Tested with 5.5.5-10.1.29-MariaDB