[4.0] Remove pathway name attribute#19703
Merged
wilsonge merged 4 commits intojoomla:4.0-devfrom Feb 16, 2018
Merged
Conversation
This was referenced Feb 16, 2018
wilsonge
reviewed
Feb 16, 2018
| * @since 3.2 | ||
| * | ||
| * @expectedException RuntimeException | ||
| * @expectedException \Joomla\DI\Exception\KeyNotFoundException |
Contributor
There was a problem hiding this comment.
Can we keep b/c on this bit please. It's easy to add a has check on the container and throw the same RuntimeException we did in the Pathway::getInstance method
Contributor
There was a problem hiding this comment.
if (!$this->getContainer()->has(ucfirst($name) . 'Pathway'))
{
throw new \RuntimeException(\JText::sprintf('JLIB_APPLICATION_ERROR_PATHWAY_LOAD', $name), 500);
}
In the getPathway method
Member
Author
|
Now travis is happy again on 4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
As discussed in #19672 the name attribute for the getPathway function should be removed as the container is the store to manage the different pathway objects.
Additionally the unit tests get fixed.