Forward port of the output buffering check fix to 3.9#19612
Merged
wilsonge merged 7 commits intojoomla:3.10-devfrom May 15, 2018
Merged
Forward port of the output buffering check fix to 3.9#19612wilsonge merged 7 commits intojoomla:3.10-devfrom
wilsonge merged 7 commits intojoomla:3.10-devfrom
Conversation
This was referenced Feb 8, 2018
Contributor
|
@zero-24 shouldnt this be against the 3.9 branch and not staging? |
Contributor
Author
|
Yes thanks @brianteeman fixed |
Contributor
Author
Contributor
|
Should be like PR for staging branch |
Contributor
Author
|
Fixed. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #19033 & #19611
Summary of Changes
In case
output_bufferingis set toOffwe should show it set off currently we show it to be enabled.Testing Instructions
review. As i can't remember how to trigger this page. But it is just a forward port of the same code used in the 3.8 PR.
Expected result
Showed as off
Actual result
showed as on
Documentation Changes Required
none