[4.0] Enforced expected parameter type#19574
Closed
demis-palma wants to merge 1 commit intojoomla:4.0-devfrom
Closed
[4.0] Enforced expected parameter type#19574demis-palma wants to merge 1 commit intojoomla:4.0-devfrom
demis-palma wants to merge 1 commit intojoomla:4.0-devfrom
Conversation
Contributor
|
FYI you don't need to do PRs for both 3.x (staging/3.9-dev) and 4.x (4.0-dev). Albeit slowly, stuff is getting merged from staging into both 3.9-dev and 4.0-dev branches, so if you fix an issue in one branch it'll get applied everywhere. |
Contributor
Author
|
I suspected something like this, but I wasn't sure because the patch is slightly different in the two branches. |
Contributor
|
IMO this here can be closed as the other PR should be merged in 4.0 too by updating 4.0 with staging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
The method getTemplate() implemented in CMSApplication, SiteApplication and AdministratorApplication wants a bool as unique parameter.
Currently there are a few occurrences where a string is passed instead, which incidentally assumes the intended value (true) when implicitly converted to bool:
(bool)'template' → true
Testing Instructions
To be merged on code review.
Fixed on staging too.