Skip to content

[4.0] php 7.2 compatibility#19216

Closed
brianteeman wants to merge 3 commits intojoomla:4.0-devfrom
brianteeman:72count40
Closed

[4.0] php 7.2 compatibility#19216
brianteeman wants to merge 3 commits intojoomla:4.0-devfrom
brianteeman:72count40

Conversation

@brianteeman
Copy link
Copy Markdown
Contributor

@brianteeman brianteeman commented Dec 29, 2017

Due to a change With php 7.2 the control panel shows several errors with the article related modules

Warning: count(): Parameter must be an array or an object that implements Countable in C:\Apache24\htdocs\cms4\administrator\components\com_content\Model\ArticlesModel.php on line 307

@brianteeman
[4.0] php 7.2 compatibility
8b6a409 
Due to a change With php 7.2 the control panel shows several errors with the article related modules

> Warning: count(): Parameter must be an array or an object that implements Countable in C:\Apache24\htdocs\cms4\administrator\components\com_content\Model\ArticlesModel.php on line 307
@mbabker
Copy link
Copy Markdown
Contributor

mbabker commented Dec 29, 2017

Since #18438 was merged this should be fixed by branch merging staging -> 3.9 -> 4.0. GitHub says the 4.0 branch is 130 commits behind staging right now so there's a bit of work waiting whenever the merge happens next.

@brianteeman
Copy link
Copy Markdown
Contributor Author

brianteeman commented Dec 29, 2017

OK will leave open for now and hope that @wilonge brings 4.0 upto date and then if not needed then this can be closed

@wilsonge
Copy link
Copy Markdown
Contributor

wilsonge commented Dec 30, 2017

Shame that person doesn't exist on github :P cause sounds like a tough one for him :) (i'll get on it tomorrow)

@brianteeman brianteeman mentioned this pull request Jan 17, 2018
Merged
@anuragteapot anuragteapot mentioned this pull request Feb 9, 2018
Closed
@brianteeman
Copy link
Copy Markdown
Contributor Author

brianteeman commented Feb 14, 2018

i'll get on it tomorrow)

Is it tomorrow yet?

@wilsonge
Copy link
Copy Markdown
Contributor

wilsonge commented Feb 14, 2018

Kinda - i got 3.8.3 merged as of Tuesday and I've made a start on 3.8.5 locally

@wilsonge
Copy link
Copy Markdown
Contributor

wilsonge commented Feb 14, 2018

In fact actually it is

joomla-cms/administrator/components/com_content/Model/ArticlesModel.php

Lines 302 to 305 in 9b719ee

if (!is_array($categoryId))
{
$categoryId = $categoryId ? array($categoryId) : array();
}
is the fix @mbabker mentioned that went into 3.8.3 - so closing this

@wilsonge wilsonge closed this Feb 14, 2018
@wilsonge
Copy link
Copy Markdown
Contributor

wilsonge commented Feb 14, 2018

Thanks for the prod tho!

@brianteeman brianteeman deleted the 72count40 branch February 15, 2018 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@brianteeman @mbabker @wilsonge @joomla-cms-bot