[4.0] Custom events: support in showon, templates, switcher, color field, tinymce#18864
Merged
wilsonge merged 8 commits intojoomla:4.0-devfrom Nov 28, 2017
Merged
[4.0] Custom events: support in showon, templates, switcher, color field, tinymce#18864wilsonge merged 8 commits intojoomla:4.0-devfrom
wilsonge merged 8 commits intojoomla:4.0-devfrom
Conversation
dgrammatiko
approved these changes
Nov 25, 2017
C-Lodder
approved these changes
Nov 26, 2017
Contributor
|
Can you fix conflicts please? |
Conflicts: administrator/templates/atum/js/template.js
Member
Author
|
@wilsonge done |
wilsonge
reviewed
Nov 27, 2017
| */ | ||
|
|
||
| (function() { | ||
| !(function(document) { |
Contributor
There was a problem hiding this comment.
Whats the ! for here? or is this a bug?
Member
There was a problem hiding this comment.
Not needed as the function is already invoked. @Fedik aren't you thinking of ; (semicolon)?
Member
Author
There was a problem hiding this comment.
! or ; is just a different "style",
@wilsonge no it not a bug, but it need to prevent a bugs, for case when file will be merged in single one.
Example file1js has:
function doStuff (blabla) {
}
and switcher.js:
(function() {
...
})();after merging we get:
function doStuff (blabla) {
}
(function() {
... switcher code
})();
after merging while parsing the "switcher" function WILL execute doStuff method from previous file, and pass a null to blabla variable.
! or ; will prevent this:
function doStuff (blabla) {
}
!(function() {
... switcher code
})();
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
As part of #16016
this pull add support of custom event
joomla:updatedto showon, templates, switcher, color field, tinymceTesting Instructions
for testing can use next XML
Expected result
All fields should work
Documentation Changes Required
nope
ping @DGT41 @wilsonge