Update sidebar toggle layout for aria#18362
Merged
mbabker merged 2 commits intojoomla:stagingfrom Oct 24, 2017
Merged
Conversation
This PR updates the toggle sidebar layout used in the admin eg com_content It ensures that there is an aria-label and that the icon is hidden as per the fontawesome recommendations applied elsewhere
Contributor
|
I have tested this item ✅ successfully on 96b46be This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18362. |
infograf768
reviewed
Oct 18, 2017
| $main.removeClass('span12 expanded').addClass('span10'); | ||
| $toggleSidebarIcon.removeClass(closedIcon).addClass(openIcon); | ||
| $toggleButton.attr( 'data-original-title', Joomla.JText._('JTOGGLE_HIDE_SIDEBAR') ); | ||
| $toggleButton.attr( 'aria-label', Joomla.JText._('JTOGGLE_HIDE_SIDEBAR') ); |
Member
There was a problem hiding this comment.
Extraneous tabs after the ; for both lines added 370 and 395
Contributor
Author
There was a problem hiding this comment.
Good spot. I can't edit those in github.com from my tablet so will have to do it later tonight
Thanks @Quy
|
@Quy can you please describe how you test? This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18362. |
Contributor
|
In Firefox, enable Developer Toolbar Before PR: After PR: |
|
I have tested this item ✅ successfully on 96b46be This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18362. |
|
RTC after two successful tests. |
Contributor
Author
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the toggle sidebar layout used in the admin eg com_content
It ensures that there is an aria-label and that the icon is hidden as per the fontawesome recommendations applied elsewhere