Skip to content

Remove notice in com_content legacyrouting#18271

Merged
wilsonge merged 1 commit intojoomla:stagingfrom
csthomas:remove_notice
Oct 9, 2017
Merged

Remove notice in com_content legacyrouting#18271
wilsonge merged 1 commit intojoomla:stagingfrom
csthomas:remove_notice

Conversation

@csthomas
Copy link
Copy Markdown
Contributor

@csthomas csthomas commented Oct 7, 2017

Summary of Changes

Do not raise PHP Notice when build URL from invalid query.

Testing Instructions

  1. Install Joomla staging without sample data.
    • Search Engine Friendly URLs is enabled by default.
  2. Set Global Configuration -> Server -> Error Reporting to Maximum.
  3. Create one featured article with text:
<p><a href="index.php?option=com_content&amp;view=featured&amp;id=1">Broken link to featured view</a></p>
  1. Go to home page and check your error_log

Expected result

No PHP Notice

Actual result

PHP notice like:

Notice: Undefined index: id in .../components/com_content/helpers/legacyrouter.php on line 97

@ggppdk
Copy link
Copy Markdown
Contributor

ggppdk commented Oct 7, 2017

I have tested this item ✅ successfully on 0cb88f9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18271.

1 similar comment
@Quy
Copy link
Copy Markdown
Contributor

Quy commented Oct 7, 2017

I have tested this item ✅ successfully on 0cb88f9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18271.

@ghost
Copy link
Copy Markdown

ghost commented Oct 8, 2017

RTC after two successful tests.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 8, 2017
@zero-24 zero-24 added this to the Joomla 3.8.2 milestone Oct 8, 2017
@wilsonge wilsonge merged commit de88137 into joomla:staging Oct 9, 2017
@joomla-cms-bot joomla-cms-bot added PR-staging and removed RTC This Pull Request is Ready To Commit labels Oct 9, 2017
@csthomas csthomas deleted the remove_notice branch October 16, 2017 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants