Schedule featured articles #13596 by eshiol · Pull Request #18052 · joomla/joomla-cms

eshiol · 2017-09-21T21:08:12Z

Pull Request for Issue #13596.

Summary of Changes

Added two fields in the article editor featured_up (Start Featured) and featured_down (End Featured)

An article is featured if featured is yes and (featured_up is null or is less than or is equal to now) and (featured_down is null or is greater than or is equal to now)

Testing Instructions

modify the database structure using the file 3.8.0-2017-09-21.sql
create 5 articles:

not featured
featured, featured_up = null, featured_down = null
featured, featured_up = tomorrow, featured_down = null
featured, featured_up = null, featured_down = yesterday
featured, featured_up = yesterday, featured_down = tomorrow

Create an Articles » Featured Articles menu item
Create a News Flash module and set the option Featured Articles to Only show Featured Articles.

Expected result

Only the articles 2 and 5 will be shown in the Articles » Featured Articles menu item and in the News Flash module.

Actual result

Documentation Changes Required

joomla-cms-bot · 2017-09-21T21:08:17Z

Please add more information to your issue. Without test instructions and/or any description we will close this issue within 4 weeks. Thanks.
This is an automated message from the J!Tracker Application.

Quy · 2017-09-21T21:17:19Z

administrator/components/com_content/models/featured.php

 				'ordering', 'a.ordering',
 				'featured', 'a.featured',
+				'featured_up', 'a.featured_up',
+				'featured_down', 'featured_down',


Quy · 2017-09-22T00:49:59Z

components/com_content/models/articles.php

 			{
 				$query->where('a.featured = 1');
 			}
+			$query->where('(a.featured_up = ' . $nullDate . ' OR a.featured_up <= ' . $nowDate . ')')


Should these lines be after $query->where('a.featured = 1');?

I don't think so. The full plain query could be produced by this piece of code

if ($this->getState('filter.frontpage')) { // filter only featured articles $query->where('a.featured = 1') ->where('(a.featured_up = ' . $nullDate . ' OR a.featured_up <= ' . $nowDate . ')') ->where('(a.featured_down = ' . $nullDate . ' OR a.featured_down >= ' . $nowDate . ')'); // join #__content_frontpage for ordering if ($orderby_sec === 'front') { $query->join('INNER', '#__content_frontpage AS fp ON fp.content_id = a.id'); } }

Articles have a row in the #__content_frontpage only if a.featured = 1, so you can optimize the query

if ($this->getState('filter.frontpage')) { if ($orderby_sec === 'front') { $query->join('INNER', '#__content_frontpage AS fp ON fp.content_id = a.id'); } else { $query->where('a.featured = 1'); } $query->where('(a.featured_up = ' . $nullDate . ' OR a.featured_up <= ' . $nowDate . ')') ->where('(a.featured_down = ' . $nullDate . ' OR a.featured_down >= ' . $nowDate . ')'); }

Quy · 2017-09-22T21:51:36Z

administrator/components/com_admin/sql/updates/sqlazure/3.8.0-2017-09-21.sql

@@ -0,0 +1,2 @@
+ALTER TABLE "#__content" ADD "featured_up" datetime2(0) NOT NULL DEFAULT '1900-01-01 00:00:00';


I don't use sqlazure so I don't know which syntax " or [] is correct.
See another PR that uses []
https://github.com/joomla/joomla-cms/pull/17709/files#diff-f6d977844dc2f4c65fe3e3262b042bd6

Quy · 2017-09-22T22:53:18Z

How about changing End to Finish to be consistent elsewhere like Finish Publishing?

WoodyF4u · 2017-09-25T13:40:21Z

Thanks for working on it to everybody who is joining this issue.
I am not a programmer or developer, so I can only watch and read.
Unfortunately it was not a part of Joomla! 3.8.0, I hope it will be part of one of the first Joomla! 3.8.x releases in the future.

Quy · 2017-09-25T14:29:56Z

administrator/language/en-GB/en-GB.com_content.ini

 COM_CONTENT_FIELD_CREATED_LABEL="Created Date"
 COM_CONTENT_FIELD_FEATURED_DESC="Assign the article to the featured blog layout."
+COM_CONTENT_FIELD_FEATURED_DOWN_DESC="An optional date to end the article being featured."
+COM_CONTENT_FIELD_FEATURED_DOWN_LABEL="End Featured"


Change to Finish

Quy · 2017-09-25T14:30:06Z

administrator/language/en-GB/en-GB.com_content.ini

 COM_CONTENT_FIELD_CREATED_DESC="Created date."
 COM_CONTENT_FIELD_CREATED_LABEL="Created Date"
 COM_CONTENT_FIELD_FEATURED_DESC="Assign the article to the featured blog layout."
+COM_CONTENT_FIELD_FEATURED_DOWN_DESC="An optional date to end the article being featured."


Change to finish

Quy · 2017-09-25T18:25:29Z

In the Featured tooltip, seconds is displayed, but not in the Publishing tooltip. To be consistent, do not display the seconds.

Quy · 2017-09-25T20:17:45Z

Installation SQLs have to be updated with the new columns.

Quy · 2017-09-26T14:36:02Z

administrator/components/com_content/helpers/html/contentadministrator.php

+					$tips[] = JText::sprintf('JLIB_HTML_FEATURED_STARTED', JHtml::_('date', $featured_up, JText::_('DATE_FORMAT_LC5'), 'UTC'));
+				}
+			}
+


Remove tabs.

Quy · 2017-09-26T14:36:18Z

administrator/components/com_content/helpers/html/contentadministrator.php

+					$tips[] = JText::sprintf('JLIB_HTML_FEATURED_FINISH', JHtml::_('date', $featured_down, JText::_('DATE_FORMAT_LC5'), 'UTC'));
+				}
+			}
+


Remove tabs.

Quy · 2017-09-26T14:37:39Z

administrator/components/com_content/helpers/html/contentadministrator.php

+		{
+			$nullDate = JFactory::getDbo()->getNullDate();
+			$nowDate = JFactory::getDate()->toUnix();
+


Remove tab.

Quy · 2017-09-26T14:37:48Z

administrator/components/com_content/helpers/html/contentadministrator.php

+
+			$featured_up = ($featured_up != $nullDate) ? JFactory::getDate($featured_up, 'UTC')->setTimeZone($tz) : false;
+			$featured_down = ($featured_down != $nullDate) ? JFactory::getDate($featured_down, 'UTC')->setTimeZone($tz) : false;
+


Remove tab.

johanpeters · 2019-01-17T09:07:27Z

Hello.. what is the current status of this feature.. when will this be released or build in the core joomla?..
i need this feature for multiple website's.. as far as i can see and have tested it it works for me..

greetings.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18052.}

HLeithner · 2019-01-17T10:57:47Z

@johanpeters 3.x series has a feature freeze, so this PR has to be ported to J4 and maybe get included in in Joomla 4.0

brianteeman · 2019-01-17T11:33:36Z

@HLeithner you really need to announce (and define) this feature freeze and then review and update ALL the existing issues and PR.

No point in having open feature PR for the J3 branch
No point in having open feature Issues for the J3 branch

AND ensure that all new PR and Issues for the J3 branch are commented on appropriately - just leaving them there just creates frustration and WASTES TIME for everyone

HLeithner · 2019-01-17T11:47:05Z

@brianteeman thats not my decision thats from the last Production meeting Report:
https://volunteers.joomla.org/departments/production/reports/936-production-meeting-december-2018

There was a discussion about . It was voted to reject this and stick to the current plan of having 3.10 as the bridge release for Joomla 4

Also reflected in the Roadmap https://developer.joomla.org/roadmap.html

Note: Joomla! 3.9 will be the last 3.x release with new features, all new features have to go into Joomla! 4.

I'm not in the position to say that this is valid for all PR's so maybe there are PR's that gets into a patch level which adds a small feature.

My comment may was not detailed enough, sry for this.

brianteeman · 2019-01-17T11:53:17Z

There is a missing word or phrase in the minutes that says what the proposal was that was discussed - the community are not mind readers

HLeithner · 2019-01-17T11:58:54Z

maybe @wilsonge can tell us more about this. I'm not part of the production team atm.

Bakual · 2019-01-17T12:24:58Z

We discussed this in the last days in the maintainers chat and George wanted to see with Sandra to write something.

brianteeman · 2019-01-17T12:29:38Z

@Bakual thank you - I had given up ever getting a reply from @wilsonge

wilsonge · 2019-04-15T10:59:18Z

Let's get this rebased onto j4 and get a fresh test. seems like a nice feature :)

joomla-cms-bot · 2019-05-11T06:23:05Z

Set to "closed" on behalf of @alikon by The JTracker Application at issues.joomla.org/joomla-cms/18052

alikon · 2019-05-11T06:23:07Z

As we are in feature freeze
all new features have to go into Joomla! 4.

Please rebase this nice feature in J4

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18052.}

…taging

Quy · 2019-08-23T14:50:00Z

PR #25979 rebased for J4

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18052.}

[New Feature] Schedule featured articles joomla#13596

2791f82

joomla-cms-bot added Language Change This is for Translators PR-staging Unit/System Tests labels Sep 21, 2017

joomla-cms-bot added the Test instructions missing label Sep 21, 2017

Quy reviewed Sep 21, 2017

View reviewed changes

fix contructor

1389dde

Quy reviewed Sep 22, 2017

View reviewed changes

Fix coding style

6527ae7

Quy reviewed Sep 22, 2017

View reviewed changes

eshiol added 3 commits September 25, 2017 15:44

Merge branch 'staging' into staging

73ba21a

Update en-GB.lib_joomla.ini

152db26

Update 3.8.0-2017-09-21.sql

a0d6cf2

Quy reviewed Sep 25, 2017

View reviewed changes

eshiol added 2 commits September 25, 2017 18:17

Update en-GB.com_content.ini

57bf154

Update contentadministrator.php

a42dbfe

eshiol added 4 commits September 26, 2017 08:35

Update joomla.sql

86fac56

Update joomla.sql

e1ebc42

Update joomla.sql

acb06c1

Update contentadministrator.php

7d4973e

Quy reviewed Sep 26, 2017

View reviewed changes

camelCase

0634c12

joomla-cms-bot changed the title ~~[New Feature] Schedule featured articles #13596~~ Schedule featured articles #13596 Mar 29, 2019

ghost added the J3 Issue label Apr 5, 2019

ghost removed the J3 Issue label Apr 19, 2019

joomla-cms-bot closed this May 11, 2019

joomla-cms-bot added the J3 Issue label May 11, 2019

ot2sen mentioned this pull request Jul 5, 2019

[Feature request] Schedule featured articles #25439

Closed

Quy reopened this Jul 5, 2019

Quy added J4 Rebase and removed J3 Issue labels Jul 5, 2019

This was referenced Aug 22, 2019

[4.0] Schedule featured articles #25978

Closed

[4.0] Schedule featured articles #25979

Merged

Merge branch 'staging' of https://github.com/joomla/joomla-cms into s…

7f7d1de

…taging

joomla-cms-bot added the PR-staging label Aug 23, 2019

Quy closed this Aug 23, 2019

Quy removed the PR-staging label Aug 23, 2019

joomla-cms-bot added the PR-staging label Aug 23, 2019

		@@ -0,0 +1,2 @@
		ALTER TABLE "#__content" ADD "featured_up" datetime2(0) NOT NULL DEFAULT '1900-01-01 00:00:00';


		$featured_up = ($featured_up != $nullDate) ? JFactory::getDate($featured_up, 'UTC')->setTimeZone($tz) : false;
		$featured_down = ($featured_down != $nullDate) ? JFactory::getDate($featured_down, 'UTC')->setTimeZone($tz) : false;

Uh oh!

Conversation

eshiol commented Sep 21, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of Changes

Testing Instructions

Expected result

Actual result

Documentation Changes Required

Uh oh!

joomla-cms-bot commented Sep 21, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Quy Sep 22, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Quy commented Sep 22, 2017

Uh oh!

WoodyF4u commented Sep 25, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Quy commented Sep 25, 2017

Uh oh!

Quy commented Sep 25, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

johanpeters commented Jan 17, 2019

Uh oh!

HLeithner commented Jan 17, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brianteeman commented Jan 17, 2019

Uh oh!

HLeithner commented Jan 17, 2019

Uh oh!

brianteeman commented Jan 17, 2019

Uh oh!

HLeithner commented Jan 17, 2019

Uh oh!

Bakual commented Jan 17, 2019

Uh oh!

brianteeman commented Jan 17, 2019

Uh oh!

wilsonge commented Apr 15, 2019

Uh oh!

joomla-cms-bot commented May 11, 2019

Uh oh!

alikon commented May 11, 2019

Uh oh!

Quy commented Aug 23, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

17 participants

eshiol commented Sep 21, 2017 •

edited

Loading

Quy Sep 22, 2017 •

edited

Loading

HLeithner commented Jan 17, 2019 •

edited

Loading