Check if array property exists.#18043
Check if array property exists.#18043jeppech wants to merge 1 commit intojoomla:stagingfrom jeppech:patch-1
Conversation
Prevents throwing ```Notice: Trying to get property of non-object in libraries/src/Component/Router/Rules/MenuRules.php on line 183```
|
can you please give more Information what your Pull Request is for also Test Instructions? |
|
I'm sorry, but I don't know how to answer that. I'm unfamiliar with how Joomla works, so I wouldn't know if it's a configuration issue, which for me, it seems not. |
|
Please ask help on the forums. This repository concerns Joomla coding. For this Reason please close this Issue, thanks. |
|
@franz-wohlkoenig This is a legitimate fix. |
|
@franz-wohlkoenig I don't see how this is not an issue, as Joomla obviously fails to check if an array property exists. |
|
@jeppech sorry, have your Comment understand wrong. |
|
Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/18043 |
|
closed as having Pull Request #18123 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18043. |
|
@franz-wohlkoenig this is a pull request as well |
|
so theres a Pull Request for a Pull Request? |
|
looks like it |
|
Set to "open" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/18043 |
|
@brianteeman thanks for Info. |
|
Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/18043 |
|
closed as duplicate Pull Request. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18043. |
|
This is really testing my patience. |
|
Can this be reopened? We might as well have 3 solutions to the same problem open. |
|
@mbabker can this please reopened? Tried at Issue Tracker got |
|
Can't be reopened, source branch for the PR has been deleted. |
Prevents throwing
Notice: Trying to get property of non-object in libraries/src/Component/Router/Rules/MenuRules.php on line 183