Skip to content

Check if array property exists.#18043

Closed
jeppech wants to merge 1 commit intojoomla:stagingfrom
jeppech:patch-1
Closed

Check if array property exists.#18043
jeppech wants to merge 1 commit intojoomla:stagingfrom
jeppech:patch-1

Conversation

@jeppech
Copy link
Copy Markdown

@jeppech jeppech commented Sep 21, 2017

Prevents throwing Notice: Trying to get property of non-object in libraries/src/Component/Router/Rules/MenuRules.php on line 183

Prevents throwing ```Notice: Trying to get property of non-object in libraries/src/Component/Router/Rules/MenuRules.php on line 183```
@ghost
Copy link
Copy Markdown

ghost commented Sep 21, 2017

can you please give more Information what your Pull Request is for also Test Instructions?

@jeppech
Copy link
Copy Markdown
Author

jeppech commented Sep 21, 2017

I'm sorry, but I don't know how to answer that. I'm unfamiliar with how Joomla works, so I wouldn't know if it's a configuration issue, which for me, it seems not.
Our company website, throws these notices: https://jeppe.ch/i/3RsAkepH.png - So this PR is just a simple check for, if an array property exists, as the title says.

@ghost
Copy link
Copy Markdown

ghost commented Sep 21, 2017

Please ask help on the forums. This repository concerns Joomla coding. For this Reason please close this Issue, thanks.

@mbabker
Copy link
Copy Markdown
Contributor

mbabker commented Sep 21, 2017

@franz-wohlkoenig This is a legitimate fix.

@jeppech
Copy link
Copy Markdown
Author

jeppech commented Sep 21, 2017

@franz-wohlkoenig I don't see how this is not an issue, as Joomla obviously fails to check if an array property exists.

@ghost
Copy link
Copy Markdown

ghost commented Sep 21, 2017

@jeppech sorry, have your Comment understand wrong.

@joomla-cms-bot
Copy link
Copy Markdown

Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/18043

@ghost
Copy link
Copy Markdown

ghost commented Sep 26, 2017

closed as having Pull Request #18123


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18043.

@brianteeman
Copy link
Copy Markdown
Contributor

@franz-wohlkoenig this is a pull request as well

@ghost
Copy link
Copy Markdown

ghost commented Sep 26, 2017

so theres a Pull Request for a Pull Request?

@brianteeman
Copy link
Copy Markdown
Contributor

looks like it

@joomla-cms-bot
Copy link
Copy Markdown

Set to "open" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/18043

@ghost
Copy link
Copy Markdown

ghost commented Sep 26, 2017

@brianteeman thanks for Info.

@Quy
Copy link
Copy Markdown
Contributor

Quy commented Sep 26, 2017

Duplicate #17323 @jeppech Please test.

@joomla-cms-bot
Copy link
Copy Markdown

Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/18043

@ghost
Copy link
Copy Markdown

ghost commented Sep 26, 2017

closed as duplicate Pull Request.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18043.

@jeppech
Copy link
Copy Markdown
Author

jeppech commented Sep 27, 2017

This is really testing my patience.
@Quy, what do you want me to test? The unmergeable PR, that hasn't been touched in two months? Or his implementation of the issue? Both of them works.
It's frustrating too see, that a 24 chars commit can start all of this.

@jeppech jeppech deleted the patch-1 branch October 20, 2017 13:23
@johannesveje
Copy link
Copy Markdown

Can this be reopened? We might as well have 3 solutions to the same problem open.

@ghost
Copy link
Copy Markdown

ghost commented Nov 13, 2017

@mbabker can this please reopened? Tried at Issue Tracker got 422 RuntimeException Invalid response from GitHub

@mbabker
Copy link
Copy Markdown
Contributor

mbabker commented Nov 13, 2017

Can't be reopened, source branch for the PR has been deleted.

@jeppech jeppech restored the patch-1 branch November 14, 2017 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants