Contact form loses data after postback with error by sandewt · Pull Request #17743 · joomla/joomla-cms

sandewt · 2017-08-28T14:05:16Z

Pull Request for issue #17126.

Summary of Changes

Some code.

Testing Instructions

Instructions, see issue #17126

Go to Single Contact.
Fill in the form.
Do not fill in captcha.
Send email.

Expected result

Warning + textboxes are NOT empty.

Actual result

All textboxes are empty, so the user has to fill in AGAIN all textboxes.

Documentation Changes Required

No.

Thanks to

@pascal-910

Pull Request for issue #17126. Testing Instructions. See issue #17126 * Go to Single Contact. * Fill in the form. * Do not fill in captcha. * Send email. Expected result: Warning + textboxes are NOT empty. So the user should not entered all text again. Actual result: All textboxes are empty, so the user has to enter again all textboxes. Thanks to: @ pascal-910.

sandewt · 2017-08-28T14:53:25Z

I'm new on Github.
If I have downloaded the code and look to the characters.
So I see in my editer, that after the "{" and the "}" braces (accolades) is a tab. In line 76 and 78. (NOK.)
How can I avoid this in github by making a PR?

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17743.}

sandewt · 2017-08-28T16:43:51Z

Ask for input.

Is the following code nessecary?

empty($item->catid)

In the DB table xxx_content is defined:

`catid` int(10) UNSIGNED NOT NULL DEFAULT '0'

So the catid may not be empty !?

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17743.}

n9iels · 2017-08-28T19:22:47Z

The patch works fine for me.

Is the following code nessecary?

There is never a problem with extra test :-). However in this situation only !empty($item->catid) is enough. !isset($item->catid) will only check if the $item object has a 'catid' property. !empty($item->catid) will check if the $item object has a 'catid' property, and this property is not empty. See this post for more information:

https://stackoverflow.com/questions/7191626/isset-and-empty-what-to-use#answer-7191642

If you change this I can conform the test via the J!Issue tracker.

sandewt · 2017-08-28T20:27:35Z

Thanks, interesting post.

Do you mean!empty($item->catid) or empty($item->catid) is enough? Because catid is not empty.
The function $app->setUserState(..) may not be executed in this situation!

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17743.}

Delete some tabs.

sandewt · 2017-09-01T08:51:12Z

Do not fiil in captcha. After send all data form loses after postback !!!

sandewt · 2017-09-01T08:53:34Z

Sorry, a mistake for closing!!

sandewt · 2017-09-23T07:00:04Z

Please test this PR #17126 or give comment.

conconnl · 2017-10-07T14:55:53Z

I have tested this item ✅ successfully on 8004b7a

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17743.}

slibbe · 2017-10-07T19:33:31Z

I have tested this item ✅ successfully on 8004b7a

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17743.}

ghost · 2017-10-08T05:44:08Z

RTC after two successful tests.

wojsmol · 2017-10-08T06:18:23Z

@franz-wohlkoenig Please see @n9iels #17743 (comment)
@sandewt Can you address this #17743 (comment)?

ghost · 2017-10-08T07:46:55Z

@wojsmol means this Comment not RTC?

wojsmol · 2017-10-08T08:02:23Z

@franz-wohlkoenig Let's leve desicion to one of maainterners. Code my to be a little simpler, but both versions works.

if (!isset($item->catid) || empty($item->catid)) changes to if (empty($item->catid))

sandewt · 2017-10-09T11:09:04Z

On closer inspection and the comments, the following:

In the Joomla! core rarely used the combination of 'isset and empty', and not for no reason.
So I choise for the proposal of @niels that one test is enough.
I expect a string for $item->catid (gettype) which is p.e. '16'. And not '' or '0'.
So I prefer 'empty' in stead of '!isset' if the user state ($app->setUserState) is not yet set.
See also: http://php.net/manual/en/types.comparisons.php

So I changed the code, PLEASE TEST AGAIN.

sandewt · 2017-10-09T11:13:29Z

Sorry for closing, issue should be open @franz-wohlkoenig.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17743.}

brianteeman · 2017-10-09T11:23:11Z

re-opened

sandewt · 2017-10-09T11:25:34Z

Thanks Brian, and @niels should be @n9iels.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17743.}

Quy · 2017-12-12T18:06:59Z

I have tested this item ✅ successfully on 9377adb

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17743.}

ghost · 2017-12-16T13:42:38Z

@conconnl @slibbe can one of you please test?

Sieger66 · 2018-01-07T01:45:33Z

I have tested this item ✅ successfully on 9377adb

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17743.}

Quy · 2018-01-07T02:26:12Z

RTC

ReLater · 2018-04-18T19:47:41Z

Looks like this pr has opened another issue. See #20195 please.

infograf768 · 2018-04-22T06:08:39Z

@sandewt
Please look at #20195 (comment)

joomla-cms-bot added the PR-staging label Aug 28, 2017

sandewt mentioned this pull request Aug 28, 2017

Contact form loses data after postback with error (ex. captcha not entered) on 3.7.3 (with maybe solution) #17126

Closed

Delete some tabs

8004b7a

Delete some tabs.

sandewt closed this Sep 1, 2017

sandewt reopened this Sep 1, 2017

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 8, 2017

Update view.html.php

9377adb

if (!isset($item->catid) || empty($item->catid)) changes to if (empty($item->catid))

sandewt closed this Oct 9, 2017

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 9, 2017

brianteeman reopened this Oct 9, 2017

Quy mentioned this pull request Oct 30, 2017

Captcha - reCaptcha - Friendly Error Message & Retaining Form Field Values on Contact Form after unsuccessful reCAPTCHA V2 submission #18450

Closed

joomla-cms-bot added RTC This Pull Request is Ready To Commit and removed RTC This Pull Request is Ready To Commit labels Jan 7, 2018

sandewt mentioned this pull request Jan 15, 2018

Fix form data lost when user registration failed #19145

Merged

ReLater mentioned this pull request Apr 18, 2018

[com_fields] Contact-Mail Custom field issue after joomla 3.8.3 #20195

Closed

sandewt mentioned this pull request Apr 23, 2018

Solves issue #20195: [com_fields] Contact-Mail Custom field issue after joomla 3.8.3 #20214

Merged

sandewt deleted the patch-1 branch April 23, 2018 08:19

sandewt restored the patch-1 branch April 23, 2018 08:21

sandewt deleted the patch-1 branch April 23, 2018 13:55

Uh oh!

Conversation

sandewt commented Aug 28, 2017 • edited by joomla-cms-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of Changes

Testing Instructions

Expected result

Actual result

Documentation Changes Required

Thanks to

Uh oh!

sandewt commented Aug 28, 2017

Uh oh!

sandewt commented Aug 28, 2017

Uh oh!

n9iels commented Aug 28, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sandewt commented Aug 28, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sandewt commented Sep 1, 2017

Uh oh!

sandewt commented Sep 1, 2017

Uh oh!

sandewt commented Sep 23, 2017

Uh oh!

conconnl commented Oct 7, 2017

Uh oh!

slibbe commented Oct 7, 2017

Uh oh!

ghost commented Oct 8, 2017

Uh oh!

wojsmol commented Oct 8, 2017

Uh oh!

ghost commented Oct 8, 2017

Uh oh!

wojsmol commented Oct 8, 2017

Uh oh!

sandewt commented Oct 9, 2017

Uh oh!

sandewt commented Oct 9, 2017

Uh oh!

brianteeman commented Oct 9, 2017

Uh oh!

sandewt commented Oct 9, 2017

Uh oh!

Quy commented Dec 12, 2017

Uh oh!

ghost commented Dec 16, 2017

Uh oh!

Sieger66 commented Jan 7, 2018

Uh oh!

Quy commented Jan 7, 2018

Uh oh!

ReLater commented Apr 18, 2018

Uh oh!

infograf768 commented Apr 22, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

sandewt commented Aug 28, 2017 •

edited by joomla-cms-bot

Loading

n9iels commented Aug 28, 2017 •

edited

Loading

sandewt commented Aug 28, 2017 •

edited

Loading