Update the postinstall to the latest news on Joomla 4.0#17549
Merged
wilsonge merged 2 commits intojoomla:stagingfrom Aug 22, 2017
Merged
Update the postinstall to the latest news on Joomla 4.0#17549wilsonge merged 2 commits intojoomla:stagingfrom
wilsonge merged 2 commits intojoomla:stagingfrom
Conversation
mbabker
approved these changes
Aug 15, 2017
wilsonge
approved these changes
Aug 15, 2017
Contributor
|
Do we need the comment about ext/mysql? Isn't that completely removed in PHP 7 |
Contributor
|
It's correct. It's saying |
Contributor
|
OK |
Contributor
|
I have tested this item ✅ successfully on 7146496 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17549. |
Contributor
|
I have tested this item ✅ successfully on e9f31bc This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17549. |
|
I have tested this item ✅ successfully on e9f31bc This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17549. |
|
RTC after two successful tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Update the postinstall to the latest news on Joomla 4.0 for PHP fixes #17547
Testing Instructions
Install Joomla on an non php 7 install
Expected result
Postinstall poping up
Actual result
postinstall come only when you are on lower than 5.5.9
Documentation Changes Required
New minimum as of https://developer.joomla.org/news/704-looking-forward-with-joomla-4.html