Set minimum width of td fields for calendar field#15928
Closed
johnkrzywanek wants to merge 1 commit intojoomla:stagingfrom
Closed
Set minimum width of td fields for calendar field#15928johnkrzywanek wants to merge 1 commit intojoomla:stagingfrom
johnkrzywanek wants to merge 1 commit intojoomla:stagingfrom
Conversation
Contributor
|
doesnt the rtl css file need updating as well? |
Contributor
|
@dmr86 can you please add your changes to the |
Contributor
|
Closing in favor of #19944 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15928. |
|
Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/15928 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
In some cases lack of set width for td element and 100% width for td with 'today' class breaks the table.
Set minimum width of td fields to 38px and removed 100% from td with 'today' class.
Testing Instructions
You can see the problem for example on Aura template from Themeforest (https://themeforest.net/item/aura-responsive-multipurpose-joomla-template/11509513), here is a screenshot from that: http://imgur.com/WOSz6FP
Expected result
All td elements in table should have the same width.
Actual result
Before the fix the td element with 'today' class tried to take as much space as possible, see here: http://imgur.com/a/T6Jgf