[4.0] Concept for sidebar navigation#15430
Conversation
|
much better than before, thanks. I suggest to reduce Sidebar to Icons, if User wants. |
|
I like the concept. To me it feels better. The constant resizing when using the menu was a bit disturbing. |
|
Looking good so far. I'll give it a proper test tomorrow.
I'll remove the jQuery and rewrite in vanilla JS fort you tomorrow too. |
|
Looks great! I'd like to have the dismiss button with more contrast, it should have conrast ratio at least 4,5. And the sidbar could have less width. But I really like the concept. Thank you, @ciar4n for your work. |
|
@Bakual Ty. As suggested I have amended so the active item is now open on page load. The slide animation is been triggered on load which I will fix once I have a little more time to look at it. This change does make your first point more apparent as the menu is now more commonly open (top-level titles hidden). Again I will try your suggestion of tooltips once I get the chance. On hiding the 'component sidebar'.. I believe there was a reason this can't be hidden. I can't remember exactly. I'm guessing something to do with 3PD? It would make a lot more sense to hide it. As you say it seems to be generally an exact copy of the 3rd level menu items. If really needed maybe they can be appended to the menu items in the sidebar or added to a second tab in the sidebar.
Thank you @chmst. I have changed the 'close' to a more stronger contrasting color as suggested... |
| while ($this->_current->hasChildren()) | ||
| { | ||
| echo '<ul id="collapse' . $unique . '" class="nav panel-collapse collapse-level-1 collapse" role="menu" aria-hidden="true"> | ||
| <li>' . $this->_current->title . '<span class="close">×</span></li>' . "\n"; |
|
@ciar4n |
I think at least being able to hide it like in J3 makes sense. We added that possibility with 3.3.7 (#4197) to get more real estate space. That argument is valid even more with J4 since the main menu is now left instead at the top. |
|
Ideally it would be nice to ensure we get the main sidebar done properly so that we can burn that annoying component sidebar |
I fear you will not be able to completely remove it. Because there are items that can't go into the regular menu. Eg when you have menu items which only show based on some conditional like the com_fields links (should only show if com_fields is active and the parameter is enabled) or maybe a link which needs special ACL permissions. |
|
Tested this: an already great improvement although some aspects are weird: |
|
I have tested this item ✅ successfully on c919fc8 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15430. |
|
|
When I click on a parent item, such as "System", then click the "close" button, if I hen want to re-open "System" again, I need to click on it twice. |
|
Hope it's a click with the top parent, not a hover. I'm not sure about the last children level - the hover and right direction is a slight change in the idea. |
|
Ciaran, I'm posting this document here for consideration, as recommended by George Wilson. |
|
@jonrz How would that on mobile / tablet |
|
@brianteeman tablets would mostly keep everything in sight. On smaller screens, it would shrink to a single column when needed, and the user would need to either scroll it, or we could have an accordion (still need to do some research on the best method). |
|
i cant see how that would work |
|
OK - was just raising awareness of the issue as you are using an icon which has direction to it now |
|
I'm gonna have to think about RTL. Not sure if the powers have a set date for a stable release of J4, but Bootstrap will most likely add RTL in 4.1 They're taking an extreme amount of time to get the first Beta pushed out, so I may grab the PR from the repo and add it as a temporary measure. |
|
A11y tabbing compatibility added... Also menu closed if on com_cpanel |
|
PR now ready for testing!) |
|
We will also need to have the flying focus on the "X" button too, so users can close the 2nd level via keyboard |
|
@C-Lodder Good point. Done. |
|
I have tested this item ✅ successfully on 1aee1fb This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15430. |
1 similar comment
|
I have tested this item ✅ successfully on 1aee1fb This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15430. |
|
RTC after two successful tests. |
|
@franz-wohlkoenig there are codestyle issue please remove RTC |
Thank you @wojsmol
|
@rdeutz Codestyle issues fixed |
|
@rdeutz set back on pending. |



For now this a concept. If preferred it would require some further work.
Comparisons over the current sidebar
Removed the sidebar toggle. Considering Joomla requires a user to access multiple areas for common tasks, I am not really in favor of hiding the sidebar. Arguments against are to increase the main area width however personally I think we can tackle this in other ways. A minor detail. The toggle can be easily added.@brianteeman @armenos I have added some minor a11y improvements (tabbing) however will need some further work.
Know issues..
Needs further a11y improvementNeeds CSS refactoringjQuery needs conversion to VanillaSome random active highlighting border in Chrome.Testing Instructions
Apply patch and navigate sidebar.