Merged
Conversation
This reverts commit 8072e58.
Contributor
Author
Contributor
|
I have just send you a PR for the drone error. The phpunit thing looks strange to me on a first quick look. I need to check that with @yvesh |
Brian a11y
fixes unit tests thanks @yvesh
Contributor
|
Travis is green now too. Thanks @yvesh and @brianteeman |
Contributor
Author
Contributor
Author
|
any testers? |
|
@brianteeman is this code review or how to test? |
Contributor
|
I have tested this item ✅ successfully on 58ee500 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15046. |
Contributor
|
I have tested this item ✅ successfully on 58ee500 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15046. |
|
RTC after two successful tests. |
Contributor
Author
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuing the work to prevent assistive technology reading out the value of an icon. This PR addresses the icons in com_contact, com_messages, com_contact an com_redirect as show in the screenshots below.