A fix for count() misuse / Catchable fatal error (ref #14873)#14982
Closed
tgv604 wants to merge 2 commits intojoomla:stagingfrom
tgv604:patch-1
Closed
A fix for count() misuse / Catchable fatal error (ref #14873)#14982tgv604 wants to merge 2 commits intojoomla:stagingfrom tgv604:patch-1
tgv604 wants to merge 2 commits intojoomla:stagingfrom
tgv604:patch-1
Conversation
please see issue #14873 line 382 assigns $this->_children = false, but count(boolean) is always 1, that causes the sorting block to execute and fail with fatal error. if ($this->_children) would fix this bug, if (count($this->_children) > 1) fixes the bug and skips sorting of one-member arrays
|
Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/14982 |
Contributor
|
See #19396 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14982. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
line 382 assigns $this->_children = false, but count(boolean) is always 1, that causes the sorting block to execute and fail with fatal error.
if ($this->_children) would fix this bug,
if (count($this->_children) > 1) fixes the bug and skips sorting of one-member arrays
Pull Request for Issue #14873.