Tiny JLanguage::loadLanguage() code improvement#14653
Closed
Hackwar wants to merge 2 commits intojoomla:stagingfrom
Closed
Tiny JLanguage::loadLanguage() code improvement#14653Hackwar wants to merge 2 commits intojoomla:stagingfrom
Hackwar wants to merge 2 commits intojoomla:stagingfrom
Conversation
|
I have tested this item ✅ successfully on ee0b0a0 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14653. |
Contributor
That's true, but it isn't what is tested there. That check tests if The code change itself should be fine, since
When I look at the code, that change should be testable by deleting/renaming a language file that is supposed to be loaded. If everything works and no errors logged then it is fine. |
Bakual
approved these changes
Mar 15, 2017
Contributor
|
Please fix conflicts. Thanks. |
|
Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/14653 |
Contributor
|
See PR #20257 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14653. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simplifies the code slightly. The additional if() is unnecessary. The $strings variable is always defined and the if() does contain nothing else than yet another if(). This change is not really testable and requires a code review.