Skip to content

Mssql file - replace 2 byte unicode whitespace to ascii 1 byte#14133

Merged
zero-24 merged 1 commit intojoomla:stagingfrom
csthomas:mssql_delete_unicode_space
Feb 18, 2017
Merged

Mssql file - replace 2 byte unicode whitespace to ascii 1 byte#14133
zero-24 merged 1 commit intojoomla:stagingfrom
csthomas:mssql_delete_unicode_space

Conversation

@csthomas
Copy link
Copy Markdown
Contributor

@csthomas csthomas commented Feb 18, 2017 •
edited
Loading

Summary of Changes

The changed file contained 2 byte utf-8 char which geneated error on my virtualbox windows 7 with sqlsrv.

CREATE TABLE [j37_fields_categories] ( 
        [field_id] [int] NOT NULL DEFAULT 0,   
        [category_id] [int] NOT NULL DEFAULT 0,   
CONSTRAINT [PK_j37_fields_categories_id] PRIMARY KEY CLUSTERED(
        [field_id] ASC, 
        [category_id] ASC)
WITH (PAD_INDEX = OFF, STATISTICS_NORECOMPUTE = OFF, IGNORE_DUP_KEY = OFF, ALLOW
_ROW_LOCKS = ON, ALLOW_PAGE_LOCKS = ON
) ON [PRIMARY]) ON [PRIMARY];

[Microsoft][ODBC Driver 11 for SQL Server][SQL Server]Incorrect syntax near ' '

This PR replace 2-byte white space char to 1 byte white space.

Testing Instructions

Merge by code review.

@zero-24 zero-24 added this to the Joomla 3.7.0 milestone Feb 18, 2017
@zero-24
Copy link
Copy Markdown
Contributor

zero-24 commented Feb 18, 2017

Merging on review thanks @csthomas

@zero-24 zero-24 merged commit 1a01810 into joomla:staging Feb 18, 2017
@csthomas csthomas deleted the mssql_delete_unicode_space branch February 18, 2017 17:24
@csthomas csthomas mentioned this pull request Feb 18, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Joomla 3.7.0

Development

Successfully merging this pull request may close these issues.

3 participants

@csthomas @zero-24 @joomla-cms-bot