Sync columns in contact_details table, add missing defaults, clean up#14113
Merged
rdeutz merged 3 commits intojoomla:stagingfrom Feb 19, 2017
Merged
Sync columns in contact_details table, add missing defaults, clean up#14113rdeutz merged 3 commits intojoomla:stagingfrom
rdeutz merged 3 commits intojoomla:stagingfrom
Conversation
Contributor
|
I have tested this item ✅ successfully on 308e1d3 Please note that I only tested it on MySQL. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14113. |
Contributor
|
I have tested this item ✅ successfully on 308e1d3 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/14113. |
Contributor
|
@csthomas could you have a look if I fixed the conflicts right |
Contributor
Author
|
It is OK |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for issue #13289
To help #7680 on mssql
Summary of Changes
metakey, metadesc- column type TEXT can not have default value for mysqlRemove
DEFAULT NULLor aloneNULLfrom sql files because this is redundant.Clean up for postgresql:
Replace
DEFAULT 0 NOT NULLtoNOT NULL DEFAULT 0Info:
https://github.com/joomla/joomla-cms/blob/staging/installation/sql/postgresql/joomla.sql#L264
https://github.com/joomla/joomla-cms/blob/staging/installation/sql/mysql/joomla.sql#L287
Testing Instructions
Install joomla with applied changes.
Installation should pass on all databases.
Test create contact.