Fix issue with callback cache controller hashing Closures#14057
Merged
wilsonge merged 2 commits intojoomla:stagingfrom Feb 14, 2017
mbabker:cache-closure-fix
Merged
Fix issue with callback cache controller hashing Closures#14057wilsonge merged 2 commits intojoomla:stagingfrom mbabker:cache-closure-fix
wilsonge merged 2 commits intojoomla:stagingfrom
mbabker:cache-closure-fix
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
When using a Closure with the cache's callback controller, generating the ID will fail because it attempts to serialize a Closure which isn't allowed. Change the code to use an object hash for the Closure instead.
Testing Instructions
Probably should be easily triggered just by turning on caching for core because there are a few places where Closures are used now. Failing that, I guess something like this should work as a test case:
Expected result
Page displays correctly
Actual result
Page errors out due to attempted serialization of a Closure
Documentation Changes Required
N/A