Convert the system Redirect plugin to use lowercase urls at all times…#13853
Convert the system Redirect plugin to use lowercase urls at all times…#13853rdeutz merged 3 commits intojoomla:stagingfrom
Conversation
… for redirecting.
|
guess testing on legacy routing? |
|
Testing is for Default router, not the new Router since that is disabled by default and doesn't appear to work with the redirects component. |
|
I have tested this item ✅ successfully on deae8cd With PR:Original-URL: index.php/sample-sites
One disabled Redirect Same without PR got two Redirect
Test on:Joomla! 3.7.0-beta1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13853. |
|
I have tested this item ✅ successfully on deae8cd This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13853. |
|
RTC #jc17de This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13853. |
|
Please don't comment on a closed issue. It won't be seen. Please create a new issue and reference this |
|
As brain said please open a new issue. The problem with your scenario is it is not directly related to Joomla! This change follows Joomla! Standards directly, where uppercase characters are not used within URLs and the redirects component is for this. Plus you couldn't create a redirect uppercase and lowercase as it conflicts its self due to the way joomla handles it. It is also good practice to not have uppercase characters in urls. In your scenario you could create a little custom plugin which bypasses this, or use one of the many sef components. |
|
ok, thanks |
|
You are welcome, it may also be worth pointing or most modern web servers treat upper and lower case equally and they are no longer unique see: https://github.com/joomla/joomla-cmS Is the same as https://github.com/joomla/joomla-cms You may want to look at update the server and add the required module to handle this accordingly. |
Pull Request for Issue # .
Summary of Changes
Converted the Redirect System Plugin to store in lowercase and match redirect on lowercase. I've gone for strtolower since it's url based. But we could replace it with mb_strtolower for UTF-8 standards if you think it is needed but it is slower.
Testing Instructions
Create an article on your website say: my-article and access it in the frontend. Perfect. remove e from it so change the url to say: mywebsite.com/inde.php/my-articl and now you get a 404, next change it to mywebsite.com/inde.php/My-articl and you get a 404. But you now have two redirects to do in the redirects component.
Expected result
upper and lowercase 404 urls show be equal since J! stores menu item aliases in lowercase.
Actual result
both lowercase and uppercase 404's are stored and matched independently.
Documentation Changes Required
Resolves #12666