[com_associations] moved "checked out" check to a helper function#13758
[com_associations] moved "checked out" check to a helper function#13758jeckodevelopment merged 2 commits intojoomla:stagingfrom
Conversation
|
i've logged in in browser A with admin1 after applying the patch, on browser B i see the locked icon on article IT and it associated article GB |
|
I didn't changed the article view I only worked on the associations view. Seems to me that is as it was before |
|
sorry i was confused by
|
|
I have tested this item ✅ successfully on 6e67ba1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13758. |
|
Not sure it works as should. Maybe need clearer test instructions. User2 using BrowserB is a manager with access to com_associations.
Now I click on the article title and I get this.
As you can see, not only I can click on an item which is locked, but also I get weird results in the side by side and when closing and although the user/manager has no com_checkin permissions, the article is unlocked and the associated article (FR in this case) is locked. |
|
I have tested this item 🔴 unsuccessfully on 6e67ba1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13758. |
|
Ok got it. This here moved the check if something is checked out to a helper function. The question at hand is, what is the right behaviour? a) If we say the article at the left is something like the source than it doesn't makes any sense to edit this or on the associated articles (because some is changing the source). b) If this can be source or target than it is much more complicated. What we can do is to disable the link on the article in the associations view, when the article is checked out |
If the item at the left is checked out nothing can be done till the item is checked in
|
I made a fix following the a) behaviour |
|
OK now: a locked item as well as its associations button (when present) do not open the side by side. There are other issues to solve but I can mark this as tested OK for what it already does. |
|
I have tested this item ✅ successfully on 14c6fcb This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13758. |
|
@alikon |
|
hope i've not missed some test case this turn ;) |
|
I have tested this item ✅ successfully on 14c6fcb This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13758. |
|
so we can set RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13758. |
Summary of Changes
This PR moves the check if an item is checked out to the helper function and used this function when creating links to items
Testing Instructions
You will see that you can access an checked out article, this end with an error message but that's not nice.
Apply the patch
Now you can see that articles have the locked sign and also the associated items don't have a link to open it.