Replace unnecessary double quotes in templates#13245
Merged
wilsonge merged 3 commits intojoomla:stagingfrom Dec 18, 2016
frankmayer:replace-unnecessary-double-quotes-in-templates
Merged
Replace unnecessary double quotes in templates#13245wilsonge merged 3 commits intojoomla:stagingfrom frankmayer:replace-unnecessary-double-quotes-in-templates
wilsonge merged 3 commits intojoomla:stagingfrom
frankmayer:replace-unnecessary-double-quotes-in-templates
Conversation
templates/protostar/index.php
Outdated
| if ($this->params->get('templateColor')) | ||
| { | ||
| $this->addStyleDeclaration(" | ||
| $this->addStyleDeclaration( |
Contributor
There was a problem hiding this comment.
Why are you opening/closing this in a new line? IMHO is more readable the old way, but of course this is a detail and most probably there is no cs rule for that
Contributor
Author
There was a problem hiding this comment.
It's in the formatting rule of the ide. Need to change it. Will make a new commit.
BTW, why are you sometimes doing "approvals" only code and other times it's "testing with code review" ? I am asking because with the first procedure it seems to take longer to get through the process (to the next stage, RTC for example). This seems to correlate to the fact that in the first procedure the number of checks stay 2 instead of the 3 tests in the second procedure. (3rd being the human tests)
templates/protostar/offline.php
Outdated
| { | ||
| $this->addStyleDeclaration(" | ||
| $this->addStyleDeclaration( | ||
| ' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR is part of a set to try to separate some of the changes done in one of my previous batch PR's for the templates directory, which is still on hold (#12233).
Once the new set is merged it will hopefully reduce the changes in that PR, so it can be reviewed easier and finally be merged.
The changes in this PR are only of two types and should be fairly easy to review. In hope that this will get merged quickly. ;)
Testing Instructions
None, should not change behavior
Documentation Changes Required
None.