Skip to content

Various changes in libraries legacy#13241

Merged
rdeutz merged 5 commits intojoomla:stagingfrom
frankmayer:various-changes-in-libraries-legacy
Dec 18, 2016
Merged

Various changes in libraries legacy#13241
rdeutz merged 5 commits intojoomla:stagingfrom
frankmayer:various-changes-in-libraries-legacy

Conversation

@frankmayer
Copy link
Copy Markdown
Contributor

@frankmayer frankmayer commented Dec 16, 2016

Summary of Changes

  • Inline one-time use variables
  • Removed unnecessary ternary operators
  • Merge unset() calls
  • Use modern day type-casting
  • This can be replaced with type-casting

This PR is part of a set to try to separate some of the changes done in one of my previous batch PR's for the libraries/legacy directory, which is still on hold (#12220).
Once the new set is merged it will hopefully reduce the changes in that PR, so it can be reviewed easier and finally be merged.

The changes in this PR should be fairly easy to review. In hope that this will get merged quickly. ;)

Testing Instructions

None, should not change behavior

Documentation Changes Required

None.

@RonakParmar
Copy link
Copy Markdown

I have tested this item ✅ successfully on cf060f6

Done code review.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13241.

@anibalsanchez
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on cf060f6

Test OK


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13241.

@jeckodevelopment
Copy link
Copy Markdown
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13241.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 18, 2016
@jeckodevelopment jeckodevelopment added this to the Joomla 3.7.0 milestone Dec 18, 2016
@rdeutz rdeutz merged commit aa583c3 into joomla:staging Dec 18, 2016
@joomla-cms-bot joomla-cms-bot added PR-staging and removed RTC This Pull Request is Ready To Commit labels Dec 18, 2016
@frankmayer frankmayer deleted the various-changes-in-libraries-legacy branch December 25, 2016 21:45
@frankmayer frankmayer mentioned this pull request Jan 6, 2017
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants