[com_joomlaupdate] Check for minimum supported database type and version by zero-24 · Pull Request #12355 · joomla/joomla-cms

zero-24 · 2016-10-08T20:09:38Z

Pull Request for Issue #12351

Summary of Changes

This implements a minimum database feature into com_joomlaupdate so we can check for minimum supported database version per type

Testing Instructions

First Please review the code.

Test the Core

Install 3.7.x (https://github.com/joomla/joomla-cms/archive/3.7.x.zip)
set this as custom update server http://www.jah-tz.de/downloads/core/nightlies/next_minor_list.xml
confirm that com_joomlaupdate still points to 3.7.0-dev2
apply this patch
confirm that com_joomlaupdate still points to 3.7.0-dev2
Do NOT install this update
change the custom update server to http://www.jah-tz.de/downloads/core/nightlies/next_minor_list2.xml
confirm that you get the We can't find a download URL .... message in com_joomlaupdate
change the custom update server to http://www.jah-tz.de/downloads/core/nightlies/next_minor_list3.xml
confirm that com_joomlaupdate still points to 3.7.0-dev2 (if you meat the requirements of mysql 5.5.3 else you should get the warning)

Test Extensions

install 3.7.x (https://github.com/joomla/joomla-cms/archive/3.7.x.zip)
install an older component of choice e.g. JCE
confirm that the update show and run as expected
install this custom component (http://www.jah-tz.de/downloads/download.php?file=plg_dbminimum.zip&folder=core/extensions/plg_dbminimum/)
confirm that it adds this update server http://www.jah-tz.de/downloads/core/extensions/plg_dbminimum/plg_dbminimum.xml (see: Backend -> Extensions -> Manage -> Update Sites)
Try to update to the next version (0.0.2)
confirm that you got a error message

Documentation Changes Required

Document the new tag if implemented as this can also be used by 3party extensions

brianteeman · 2016-10-08T20:22:11Z

administrator/language/en-GB/en-GB.lib_joomla.ini

 JLIB_INSTALLER_ABORT_TPL_INSTALL_UNKNOWN_CLIENT="Template Install: Unknown client type [%s]"
 JLIB_INSTALLER_AVAILABLE_UPDATE_PHP_VERSION="For the extension %1$s version %2$s is available, but it requires at least PHP version %3$s while your system only has %4$s"
+JLIB_INSTALLER_AVAILABLE_UPDATE_DB_MINIMUM="For the extension %1$s version %2$s is available, but your current database %3$s in version %4$s is not supported please contact your host in to update you Databseversion at least to version %5$s"
+JLIB_INSTALLER_AVAILABLE_UPDATE_DB_TYPE="For the extension %1$s version %2$s is available, but your current database %3$s is not supported anymore"


Add a full stop at the end

brianteeman · 2016-10-08T20:23:04Z

administrator/language/en-GB/en-GB.lib_joomla.ini

 JLIB_INSTALLER_ABORT_TPL_INSTALL_ROLLBACK="Template Install: %s"
 JLIB_INSTALLER_ABORT_TPL_INSTALL_UNKNOWN_CLIENT="Template Install: Unknown client type [%s]"
 JLIB_INSTALLER_AVAILABLE_UPDATE_PHP_VERSION="For the extension %1$s version %2$s is available, but it requires at least PHP version %3$s while your system only has %4$s"
+JLIB_INSTALLER_AVAILABLE_UPDATE_DB_MINIMUM="For the extension %1$s version %2$s is available, but your current database %3$s in version %4$s is not supported please contact your host in to update you Databseversion at least to version %5$s"


Lets fix the germish ;)

+JLIB_INSTALLER_AVAILABLE_UPDATE_DB_MINIMUM="For the extension %1$s version %2$s is available, but your current database %3$s is version %4$s and is not supported. Please contact your web host to update you Database version to at least version %5$s."

zero-24 · 2016-10-08T20:28:33Z

Thanks fixed @brianteeman

brianteeman · 2016-10-08T20:34:54Z

Tried to test this but at this point
change the custom update server to http://www.jah-tz.de/downloads/core/nightlies/next_minor_list2.xml
confirm that you get the You don't support the minimum .... message in com_joomlaupdate

I get the "We can't find a download URL" message

zero-24 · 2016-10-08T20:40:30Z

@brianteeman yes this is the correct message. On writing the instructions i did not had the title in my mind.

brianteeman · 2016-10-08T20:43:12Z

confirm that com_joomlaupdate still points to 3.7.0-dev2 (if you meat the requirements of mysql 5.5.3 else you should get the warning)

Is there any way I can test this? Maybe you can force it to look for a minimum requirement of 9.9?

zero-24 · 2016-10-08T20:46:33Z

i have just fixed the instructions thanks!

Is there any way I can test this? Maybe you can force it to look for a minimum requirement of 9.9?

99.5.3 is used in test 2. ;) -> The reason you don't get the update

The 3. is just a test to make sure nothing breaks and you get the update if you meat the requirements

brianteeman · 2016-10-08T20:52:37Z

Extension update. The message I get is

This is confusing - the first sentence will lead me to think that the problem is that I can not connect to the update server

zero-24 · 2016-10-08T20:55:29Z

That are 2 different errors ;) The first one is from the test report extension (see: #12258) and the seccond warning is my warning so everything works as expected.

brianteeman · 2016-10-08T20:56:44Z

administrator/language/en-GB/en-GB.lib_joomla.ini

 JLIB_INSTALLER_ABORT_TPL_INSTALL_ROLLBACK="Template Install: %s"
 JLIB_INSTALLER_ABORT_TPL_INSTALL_UNKNOWN_CLIENT="Template Install: Unknown client type [%s]"
 JLIB_INSTALLER_AVAILABLE_UPDATE_PHP_VERSION="For the extension %1$s version %2$s is available, but it requires at least PHP version %3$s while your system only has %4$s"
+JLIB_INSTALLER_AVAILABLE_UPDATE_DB_MINIMUM="For the extension %1$s version %2$s is available, but your current database %3$s is version %4$s and is not supported. Please contact your web host to update you Database version to at least version %5$s."


oops - my fault - missed one

to update you Database version
==>
to update your Database version

fixed: a2647cd

brianteeman · 2016-10-08T20:57:52Z

OK - all good then. - But they are warnings - should they be errors?

Also I missed a typo

On 8 October 2016 at 21:55, zero-24 notifications@github.com wrote:

That are 2 different errors ;) The first one is from the test report
extension (see: #12258 #12258)
and the seccond warning is my warning so everything works as expected.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#12355 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8RfrxpHDyULUFVikbhfo-MY97sKGks5qyANDgaJpZM4KR0KZ
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

zero-24 · 2016-10-08T21:01:59Z

OK - all good then.

Thanks!

But they are warnings - should they be errors?

I can do both i have set is at warning as the PHP Minimum message is also just a warning.

brianteeman · 2016-10-08T21:04:32Z

I have tested this item ✅ successfully on a2647cd

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12355.}

brianteeman · 2016-10-08T21:04:33Z

OK - I am not bothered myself if its a warning or error

On 8 October 2016 at 22:02, zero-24 notifications@github.com wrote:

OK - all good then.

Thanks!

But they are warnings - should they be errors?

I can do both i have set is at warning as the PHP Minimum message is also
just a warning.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#12355 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8afmto0MtIZdiV3nmn-bYOdGgGWmks5qyATJgaJpZM4KR0KZ
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

yvesh · 2016-10-09T06:23:12Z

libraries/joomla/updater/adapters/extension.php

+								);
+
+								JFactory::getApplication()->enqueueMessage($dbMsg, 'warning');
+


One empty line too much ;)

jeckodevelopment · 2016-10-17T23:59:12Z

I have tested this item ✅ successfully on ce23227

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12355.}

brianteeman · 2016-10-18T00:02:03Z

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12355.}

brianteeman · 2016-10-18T00:02:35Z

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12355.}

zero-24 · 2016-10-18T17:43:19Z

Thanks!

zero-24 · 2017-03-18T19:11:55Z

I have just added the option supported_databases to this doku: https://docs.joomla.org/Deploying_an_Update_Server

zero-24 added 4 commits October 8, 2016 18:37

initial support supported_databases

b81ec6a

fixes. Thanks Michael

5c07334

fix some typos

c1964df

oh inconsistencies where you look ... great updater code

591d0da

joomla-cms-bot added Language Change This is for Translators PR-staging labels Oct 8, 2016

zero-24 mentioned this pull request Oct 8, 2016

[RFC] Check for minimum supported database type and version #12351

Closed

brianteeman reviewed Oct 8, 2016

View reviewed changes

en-GB thanks @brianteeman

ecc22f9

brianteeman reviewed Oct 8, 2016

View reviewed changes

you -> your

a2647cd

yvesh reviewed Oct 9, 2016

View reviewed changes

one line to much thanks @yvesh

ce23227

zero-24 added this to the Joomla 3.7.0 milestone Oct 10, 2016

joomla-cms-bot removed the Language Change This is for Translators label Oct 18, 2016

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 18, 2016

brianteeman added Add to Release Notes Documentation Required labels Oct 18, 2016

zero-24 added Feature and removed Add to Release Notes labels Oct 18, 2016

rdeutz merged commit 0af7caf into joomla:staging Oct 18, 2016

zero-24 deleted the database_minimum branch October 18, 2016 17:43

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 18, 2016

andrepereiradasilva mentioned this pull request Oct 19, 2016

Deprecate #__utf8_conversion and remove it #12479

Closed

zero-24 removed the Documentation Required label Mar 18, 2017

zero-24 mentioned this pull request Sep 4, 2017

[3.9] Pre Update Checker why using hardcoded database version check? #17871

Closed

		);

		JFactory::getApplication()->enqueueMessage($dbMsg, 'warning');

Uh oh!

Conversation

zero-24 commented Oct 8, 2016 • edited by joomla-cms-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of Changes

Testing Instructions

Test the Core

Test Extensions

Documentation Changes Required

Uh oh!

brianteeman Oct 8, 2016

Choose a reason for hiding this comment

Uh oh!

brianteeman Oct 8, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zero-24 commented Oct 8, 2016

Uh oh!

brianteeman commented Oct 8, 2016

Uh oh!

zero-24 commented Oct 8, 2016

Uh oh!

brianteeman commented Oct 8, 2016

Uh oh!

zero-24 commented Oct 8, 2016

Uh oh!

brianteeman commented Oct 8, 2016

Uh oh!

zero-24 commented Oct 8, 2016

Uh oh!

brianteeman Oct 8, 2016

Choose a reason for hiding this comment

Uh oh!

zero-24 Oct 8, 2016

Choose a reason for hiding this comment

Uh oh!

brianteeman commented Oct 8, 2016

Uh oh!

zero-24 commented Oct 8, 2016

Uh oh!

brianteeman commented Oct 8, 2016

Uh oh!

brianteeman commented Oct 8, 2016

Uh oh!

yvesh Oct 9, 2016

Choose a reason for hiding this comment

Uh oh!

jeckodevelopment commented Oct 17, 2016

Uh oh!

brianteeman commented Oct 18, 2016

Uh oh!

brianteeman commented Oct 18, 2016

Uh oh!

zero-24 commented Oct 18, 2016

Uh oh!

zero-24 commented Mar 18, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

zero-24 commented Oct 8, 2016 •

edited by joomla-cms-bot

Loading

brianteeman Oct 8, 2016 •

edited

Loading