Cleanups, fixes and a bit of optimizations for site/components batch #2#12291
Merged
rdeutz merged 2 commits intojoomla:stagingfrom Oct 18, 2016
frankmayer:site-com_contact
Merged
Cleanups, fixes and a bit of optimizations for site/components batch #2#12291rdeutz merged 2 commits intojoomla:stagingfrom frankmayer:site-com_contact
rdeutz merged 2 commits intojoomla:stagingfrom
frankmayer:site-com_contact
Conversation
- com_contact Note: This is a single commit bundling all types of changes, since PR #12261 which had detailed commits, was rejected as a whole
| $temp = new Registry; | ||
| $temp->loadString($item->params); | ||
| $item->params = clone($this->params); | ||
| $item->params = clone$this->params; |
Contributor
There was a problem hiding this comment.
can you add a space here?
Contributor
|
I have tested this item ✅ successfully on 2372fcb This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12291. |
Contributor
|
RTC on review for 3.6.4 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12291. |
Contributor
|
Milestone changed to 3.7 as it is now not planned to have a 3.6.4 release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This is a single commit bundling all types of changes, since PR #12261 which had detailed commits, was rejected as a whole