Cleaned up writeDynaList() and it's only usage#12282
Closed
milux wants to merge 1 commit intojoomla:4.0-devfrom
Closed
Cleaned up writeDynaList() and it's only usage#12282milux wants to merge 1 commit intojoomla:4.0-devfrom
milux wants to merge 1 commit intojoomla:4.0-devfrom
Conversation
Contributor
Contributor
Merged
Contributor
|
I am closing this as it appears that writeDynaList has been removed from the core.js file and the bug in moduleorder.js resolved. Probably here 3d976e4#diff-dff3a13ca1c06afc73dd123e9f435fd1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Function writeDynaList() in core.js was cleaned up. Conforming to its only usage one redundant parameter was removed. The function now always requires the last argument (element) and cannot anymore write to the document directly, because usage of
document.write()anddocument.writeln()is a questionable approach, better replaced by DOM manipulation.Testing Instructions
none
Documentation Changes Required
I'm not aware of any documentation about this function, so most likely none.