Handle PHP error if download url comes back as false#12187
Merged
Conversation
zero-24
reviewed
Sep 28, 2016
| return false; | ||
| } | ||
|
|
||
| $package_url = trim($downloadUrlElement->_data); |
Contributor
There was a problem hiding this comment.
Maybe we can remove this variable and direct return the result of trim?
Contributor
|
I have tested this item ✅ successfully on e13a659 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12187. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on e13a659 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12187. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12187. |
Contributor
|
Removed RTC label |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Fix edge case when you are on a Joomla site of a version higher than allowed by a language pack that no download url is available causing a Joomla error
Testing Instructions
Bump the version in the
libraries/cms/version/version.phpfile to 3.8 or higher (4.0 etc). Then try and install a language through the Install Language area in the installer component. Note that a PHP notice will flash up on your screen. Apply patch and no more errorsDocumentation Changes Required
None