Bugtracker #28333: JFTP call "DL" function that sometimes is removed by ...#1209
Merged
mbabker merged 1 commit intojoomla:2.5.xfrom Aug 24, 2013
Merged
Bugtracker #28333: JFTP call "DL" function that sometimes is removed by ...#1209mbabker merged 1 commit intojoomla:2.5.xfrom
mbabker merged 1 commit intojoomla:2.5.xfrom
Conversation
…moved by hosting environment and cause fatal error without message The fix is present in Joomla 2.5 and not present in 3.1 The reason of the issue is due to the fact that the "dl" function is called event when FTP layer is not used. As soon as a jimport load the FTP client somewhere it cause a fatal error that is hide due to the "@dl" that does not report error. The fix consists in checking that function "dl" exists before calling it. To reproduce it, you need to setup a server that does not contain the FTP module and that does not include the "dl" function. Becarefull that most WAMP or similar include the FTP and dl in the core that can not be removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...hosting environment and cause fatal error without message
The reason of the issue is due to the fact that the "dl" function is called event when FTP layer is not used.
As soon as a jimport load the FTP client somewhere it cause a fatal error that is hide due to the "@dl" that does not report error.
The fix consists in checking that function "dl" exists before calling it.
To reproduce it, you need to setup a server that does not contain the FTP module and that does not include the "dl" function.
Becarefull that most WAMP or similar include the FTP and dl in the core that can not be removed.