XML Codestyle for the file application.xml#12080
Closed
zero-24 wants to merge 8 commits intojoomla:stagingfrom
Closed
XML Codestyle for the file application.xml#12080zero-24 wants to merge 8 commits intojoomla:stagingfrom
zero-24 wants to merge 8 commits intojoomla:stagingfrom
Conversation
andrepereiradasilva
suggested changes
Sep 19, 2016
Contributor
andrepereiradasilva
left a comment
There was a problem hiding this comment.
if we are doing a full cs review of the xml you should folllow the name, type, labeldescription order as code style rules.
| filter="integer" | ||
| showon="caching:1,2[AND]cache_handler:redis"> | ||
| showon="caching:1,2[AND]cache_handler:redis" | ||
| > |
Contributor
There was a problem hiding this comment.
add a tab here
Member
|
I have tested this item ✅ successfully on c3673d2 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12080. |
wojsmol
suggested changes
Sep 19, 2016
Contributor
|
@zero-24 @andrepereiradasilva Please see zero-24#17 |
Contributor
Author
|
Looks good just one smal comment in that PR. Thanks @wojsmol 👍 |
* XML CS fixes * Update application.xml fixed options order
andrepereiradasilva
suggested changes
Sep 20, 2016
| description="COM_CONFIG_ACTION_EDITOWN_DESC" /> | ||
| filter="rules" | ||
| > | ||
| <action |
Contributor
There was a problem hiding this comment.
why are the action idented with an extra tab? the option are not...
Contributor
Author
|
Thanks @wojsmol |
andrepereiradasilva
approved these changes
Sep 20, 2016
Contributor
|
I have tested this item ✅ successfully on 351db4e This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/12080. |
Contributor
|
cc @JoomliC Please do a code review 😄 |
Contributor
Author
|
this is now moved to be against 3.7.x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
XML Codestyle for the file
administrator/components/com_config/model/form/application.xmlTesting Instructions
Documentation Changes Required
none