Skip to content

[user notes] Category is required#11947

Merged
wilsonge merged 1 commit intojoomla:stagingfrom
andrepereiradasilva:patch-5
Sep 6, 2016
Merged

[user notes] Category is required#11947
wilsonge merged 1 commit intojoomla:stagingfrom
andrepereiradasilva:patch-5

Conversation

@andrepereiradasilva
Copy link
Copy Markdown
Contributor

@andrepereiradasilva andrepereiradasilva commented Sep 6, 2016

Summary of Changes

The user notes new/edit form is missing the required in category field.

Testing Instructions

  1. Code review

Documentation Changes Required

None.

@brianteeman
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 68a633b


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11947.

1 similar comment
@AnishaTailored
Copy link
Copy Markdown

I have tested this item ✅ successfully on 68a633b


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11947.

@brianteeman
Copy link
Copy Markdown
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11947.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 6, 2016
@brianteeman brianteeman added this to the Joomla 3.6.3 milestone Sep 6, 2016
@infograf768
Copy link
Copy Markdown
Member

is it really useful in staging as it is never empty as it defaults to uncategorised (unless that default category has been deleted) ? it looks only useful when modal_category is used, therefore in 3.7

@brianteeman
Copy link
Copy Markdown
Contributor

it fixes a bug - no reason to wait to fix a bug no matter how signifcant

@wilsonge wilsonge merged commit 5da2d09 into joomla:staging Sep 6, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 6, 2016
@wilsonge
Copy link
Copy Markdown
Contributor

wilsonge commented Sep 6, 2016

Uncategorised is often deleted I think.... I don't see any reason to not accept it tbh

@andrepereiradasilva andrepereiradasilva deleted the patch-5 branch September 6, 2016 14:25
@andrepereiradasilva
Copy link
Copy Markdown
Contributor Author

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants