Improving menu item workflow in Joomla[GSoC 16_menu_for_article_project]#11766
Closed
shubhamnba2009 wants to merge 137 commits intojoomla:stagingfrom
Closed
Improving menu item workflow in Joomla[GSoC 16_menu_for_article_project]#11766shubhamnba2009 wants to merge 137 commits intojoomla:stagingfrom
shubhamnba2009 wants to merge 137 commits intojoomla:stagingfrom
Conversation
Add changes to appear in hathor template.
Also updated en-GB.plg_content_menu.ini file according to xml file.
Also the class name is changed and made according to the Joomla coding standards.
1. Added<fieldset> tab in menu.xml so that menulink tab appears in the backend of edit view. 2. Tested the code generic functionality with com_contact component and it worked successfully. 3. Added a new functionality that make sure that the plugin works in the backend of the component.
1. Menu data is saved in the menu table. 2. Checked with content and contact component.
1. Click on already created article or contact. 2. The menu link tab fields are retrieved from the database.
Coded xml file to made a drop down list of component view in which to enable the plugin. Fixed the decapricated, getsession() method.
1. Solves the problem specified in : joomla-projects/gsoc16_menu-for-article#16 (comment) 2. Solves the problem specified in: joomla-projects/gsoc16_menu-for-article#19 3. Solves the issue specified in :
Also made necessary changes in the plugin to suit changed plugin name
Improved code style
added 7 commits
December 20, 2016 20:48
…luginpr # Conflicts: # administrator/components/com_admin/script.php # installation/sql/mysql/joomla.sql #
…luginpr # Conflicts: # installation/language/sr-YU/sr-YU.ini # installation/sql/sqlazure/joomla.sql
…la-cms into menupluginpr
# Conflicts: # administrator/templates/hathor/html/mod_menu/default_enabled.php
Contributor
|
@shubhamnba2009 Could you please resolve conflicts on this one? |
added 2 commits
February 5, 2017 15:59
…luginpr # Conflicts: # administrator/components/com_admin/script.php # installation/sql/mysql/joomla.sql # installation/sql/postgresql/joomla.sql # installation/sql/sqlazure/joomla.sql
Author
|
@puneet0191 I have noticed a new check (appveyor) is integrated now. The PR is failing its check... Any idea whom should I contact to know about it? |
…la-cms into menupluginpr
Contributor
|
@shubhamnba2009 Appveyor should be fine. If you can resolve the conflicts we can see what the automated tests do and we can follow up as needed. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/11766. |
added 3 commits
August 19, 2017 18:46
…luginpr # Conflicts: # administrator/components/com_admin/script.php # administrator/language/en-GB/install.xml # administrator/templates/hathor/html/mod_menu/default_enabled.php # installation/sql/mysql/joomla.sql # installation/sql/postgresql/joomla.sql # installation/sql/sqlazure/joomla.sql
Author
|
@roland-d I resolved the conflicts.. Let me know how the automated test does :) |
Contributor
|
@shubhamnba2009 All tests passed. Thanks 👍 |
Contributor
|
Now we just need human test. I will get some people to test next week. |
Contributor
|
Tested this and it never populates the parent item
|
Contributor
|
Further test
|
Contributor
|
This has been superceeded by #21357 and merged so closing here - thanks for all the hard work that was done here! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
In Joomla 1.0 it was possible to create a menu link to an article from the article edit view in the administrator back-end. Joomla is missing this feature since 1.5 and it has a long time since then. Content-Createmenulink plugin recreates the old memories of creating menu item directly from the component view.
Testing Instructions
Type two component view to enable component in both component view.
[Note: Remember to press enter before typing second component+view name]
Expected outcome
New menu item for the article/contact/3rd party component will get created in the frontend.