newsfeed intro image [redo]#11687
Closed
brianteeman wants to merge 7 commits intojoomla:stagingfrom
brianteeman:new_newsfeed
Closed
newsfeed intro image [redo]#11687brianteeman wants to merge 7 commits intojoomla:stagingfrom brianteeman:new_newsfeed
brianteeman wants to merge 7 commits intojoomla:stagingfrom
brianteeman:new_newsfeed
Conversation
| $image = preg_match('/http/', $introImage)? $introImage : JURI::root() . $introImage; | ||
| $item->description = '<p><img src="' . $image . '" /></p>'; | ||
| } | ||
| $item->description .= ($params->get('feed_summary', 0) ? $item->introtext . $item->fulltext : $item->introtext); |
Member
There was a problem hiding this comment.
You still need a new line after the closing if braces :-) (in view.feed.php too)
Contributor
Author
|
This PR was RTC and was merged by @rdeutz into the wrong branch so I had to redo it |
Contributor
Author
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11687. |
Contributor
|
Merged with 4058aa6 |
Contributor
Author
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #11402 .
redo for @rdeutz as it was merged in the wrong brach