Use ajax power on module order field by dgrammatiko · Pull Request #11040 · joomla/joomla-cms

dgrammatiko · 2016-07-06T20:26:58Z

Enhance the current status quo

Try to create a new module in module manager. Select a position. Select another position
The dropdown ordering doesn't really represent the true order of the modules in the new position.
So my idea was to use ajax power to be always accurate on that dropdown.

Summary of Changes

Use ajax power, tight connection with the controller module.php

Preview

Mind the untranslated string!
No other module in that position:

With other modules in the same position:

Testing

Please DO NOT TEST this one!
Instead give a vote (up or down thumb) so PLT can make a decision (or PLT decides directly, whatever comes first)

Devportobello · 2016-07-07T08:01:01Z

libraries/cms/form/field/moduleorder.php

+							"position": originalPos
+					 },
+					success:function(response) {
+					 	console.log(response.data);


debug code ?

This PR is just to showcase some working code. it's not commit ready.
Eg $("#jform_position") the relation with the position field right now is hardcoded, needs an option in the XML for the field moduleorder

Devportobello · 2016-07-07T08:49:22Z

Dunno if people use the ordering directly in edit mode, but this is an improvment when there is many module in same position

dgrammatiko · 2016-07-07T18:10:50Z

@Devportobello from a UX perspective this is the right approach.
Now is this something that people actually use? I have no clue...

RonakParmar · 2016-07-12T12:13:48Z

I have tested this item 🔴 unsuccessfully on 4885e07

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11040.}

RonakParmar · 2016-07-12T12:17:33Z

I have applied this PR and try to create "custom" module, I have jQuery error in console.
Joomla Version: Joomla! 3.6.0-rc Release Candidate [ Noether ] 28-June-2016 20:34 GMT
Tested in Ubuntu 12.04, FireFox 47.0.1.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11040.}

killoltailored · 2016-07-12T12:23:04Z

I have tested this item 🔴 unsuccessfully on 4885e07

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11040.}

killoltailored · 2016-07-12T12:29:43Z

I have tested after applying patch with Joomla Version Joomla! 3.6.0-rc Release Candidate [ Noether ] 28-June-2016 20:34 GMT in Windows 8.1, Firefox 47.0.1
Create new custom module and found jQuery error. Test with both case select unused position and used position.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11040.}

dgrammatiko · 2016-07-12T17:06:06Z

@RonakParmar @killoltailored Thanks for testing but this is RFC (Request for comments) which means a decision is needed here before I spent more time on this pr. So an up vote or down vote on the scope is enough at the moment (even if the code is not show time ready). Thanks again

brianteeman · 2016-07-12T18:17:11Z

Might have helped if you stated that!

dgrammatiko · 2016-07-12T18:35:57Z

@brianteeman I thought that RFC indicator was enough. Maybe I should have opened this as an issue without code attached so people wouldn't be able to do any testing.

brianteeman · 2016-07-12T18:42:29Z

Don't forget that we have a lot of less experienced developers and new testers. Never assume anything - when you assume you make a s ASS out of U and ME

gunjanpatel · 2016-07-14T04:58:40Z

I am sure they are testing it because they see pending status of the task. It is hard to understand what is RFC from the title of the task. 😄

It isn't should be in a "Needs Review" status? Or may just "New" status and which waiting to be "Confirmed".

Thanks.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11040.}

brianteeman · 2016-07-14T08:38:11Z

Gunman. Unfortunately any PR will show up in patch tester. Patchtester only shows if it is already RTC or not. Needs Review is an internal flag for CMS maintainers to make a decision on something. To be honest a comment that it didn't work is a reply to a request for a comment in my book :)

JoshJourney · 2016-07-21T22:22:51Z

Great idea. So who are you asking if this is worth it before working on this PR? The folks who manage PR's for new releases of Joomla? Testers?

brianteeman · 2016-08-03T18:12:12Z

@DGT41 - seems the consensus is that yes this is a good idea but that the code currently doesnt work yet

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11040.}

- Seperate html-javascript (no inline scripts) - Fix broken ajax - Fix wrong escaping - Introduce option for the linked field - No new strings

dgrammatiko · 2016-08-14T17:36:21Z

Now it should be testable

gunjanpatel · 2016-08-16T04:14:42Z

Can you remove RFC from title then?

brianteeman · 2016-08-26T10:46:49Z

Not sure if it is doing what I expect it to do
After applying the patch the ordering in the select is correct but when viewing it on the front end the ordering selected is not being used

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11040.}

dgrammatiko · 2016-08-31T16:20:20Z

@brianteeman before applying this patch was the behaviour different? All this pr is doing is reloading the ordering when the position is changed, it shouldn't interfere with the actual ordering in the front end...

andrepereiradasilva · 2016-08-31T16:25:47Z

libraries/cms/form/field/moduleorder.php

+	 *
+	 * @note    The field does not include an upload mechanism.
+	 * @see     JFormFieldMedia
+	 * @since   11.1


11.1? better always to use __DEPLOY_VERSION__

I think __DEPLOY_VERSION__ needs to be on other places too where 3.7 is added.

@andrepereiradasilva @gunjanpatel you are both right but I think __DEPLOY_VERSION__ came after july 6th. Anyways I will fix this..

ohh sorry didn't noticed dates. Thanks 👍

brianteeman · 2016-09-01T09:07:55Z

I have tested this item ✅ successfully on 9ed547e

No idea what the issue was I saw before as I cant replicate it now

I still dont really see what the difference is now though compared to before this pr

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11040.}

AnishaTailored · 2016-09-05T09:57:33Z

I have tested this item ✅ successfully on 9ed547e

I have tested this successfully. If we change the position then the ordering field fetches modules of the newly selected position.
But shouldn't Ordering dropdown be jQuery chosen dropdown as it was before this PR.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11040.}

zero-24 · 2016-09-05T16:38:40Z

@DGT41 can you double check the since tags? If that is done i think we can RTC

dgrammatiko · 2016-09-05T16:47:50Z

@zero-24 there you go!

zero-24 · 2016-09-05T18:20:19Z

libraries/cms/form/field/moduleorder.php

+	 *
+	 * @return  string  The field input markup.
+	 *
+	 * @since   11.1


I think this is missing?

getInput() was there before so the since should not change. (11.1 is wrong should be 1.6)

zero-24 · 2016-09-05T18:22:17Z

Hmm i have found two more ;)

zero-24 · 2016-09-05T18:49:43Z

Go for it @joomla-cms-bot please make us happy 😄

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11040.}

rfc

35333d3

joomla-cms-bot added the PR-staging label Jul 6, 2016

CS

4885e07

Devportobello reviewed Jul 7, 2016
View reviewed changes

dgrammatiko mentioned this pull request Jul 21, 2016

Create new Category on the fly is heavily broken #11162

Closed

Fixes:

b7f91bb

- Seperate html-javascript (no inline scripts) - Fix broken ajax - Fix wrong escaping - Introduce option for the linked field - No new strings

dgrammatiko mentioned this pull request Aug 14, 2016

Use API for inline script in module edit page (admin) #11028

Closed

core.js

9ed547e

dgrammatiko changed the title ~~RFC Use ajax power on module order field~~ Use ajax power on module order field Aug 18, 2016

dgrammatiko mentioned this pull request Aug 31, 2016

Improving menu item workflow in Joomla[GSoC 16_menu_for_article_project] #11766

Closed

andrepereiradasilva reviewed Aug 31, 2016
View reviewed changes

use Deploy_version

ccebaa0

zero-24 reviewed Sep 5, 2016
View reviewed changes

dgrammatiko added 2 commits September 5, 2016 21:34

since

f1baffb

remove extra line

c29fe07

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 5, 2016

rdeutz added this to the Joomla 3.6.3 milestone Sep 6, 2016

rdeutz merged commit 0b9b3a8 into joomla:staging Sep 6, 2016

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 6, 2016

810 mentioned this pull request Sep 8, 2016

Html broken on the new module order field #11984

Closed

dgrammatiko deleted the rfcModuleOrder branch September 8, 2016 12:50

dgrammatiko mentioned this pull request Oct 3, 2016

Tidy writeDynaList() #12184

Merged

This was referenced Oct 29, 2016

Module Positions inaccessable wit Hathor admin Template #12607

Closed

Fix for Module Positions inaccessible wit Hathor admin Template #12621

Merged

dgrammatiko mentioned this pull request Nov 30, 2016

Refactoring com_fields to no longer use com_categories #13019

Merged

Uh oh!

Conversation

dgrammatiko commented Jul 6, 2016 • edited by joomla-cms-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Enhance the current status quo

Summary of Changes

Preview

Testing

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Devportobello commented Jul 7, 2016

Uh oh!

dgrammatiko commented Jul 7, 2016

Uh oh!

RonakParmar commented Jul 12, 2016

Uh oh!

RonakParmar commented Jul 12, 2016

Uh oh!

killoltailored commented Jul 12, 2016

Uh oh!

killoltailored commented Jul 12, 2016

Uh oh!

dgrammatiko commented Jul 12, 2016

Uh oh!

brianteeman commented Jul 12, 2016 via email

Uh oh!

dgrammatiko commented Jul 12, 2016

Uh oh!

brianteeman commented Jul 12, 2016 via email

Uh oh!

gunjanpatel commented Jul 14, 2016

Uh oh!

brianteeman commented Jul 14, 2016 via email

Uh oh!

JoshJourney commented Jul 21, 2016

Uh oh!

brianteeman commented Aug 3, 2016

Uh oh!

dgrammatiko commented Aug 14, 2016

Uh oh!

gunjanpatel commented Aug 16, 2016

Uh oh!

brianteeman commented Aug 26, 2016

Uh oh!

dgrammatiko commented Aug 31, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

brianteeman commented Sep 1, 2016

Uh oh!

AnishaTailored commented Sep 5, 2016

Uh oh!

zero-24 commented Sep 5, 2016

Uh oh!

dgrammatiko commented Sep 5, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zero-24 commented Sep 5, 2016

Uh oh!

zero-24 commented Sep 5, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

dgrammatiko commented Jul 6, 2016 •

edited by joomla-cms-bot

Loading