Skip to content

Properly align content after XTD buttons#10970

Closed
dgrammatiko wants to merge 2 commits intojoomla:stagingfrom
dgrammatiko:clearfix
Closed

Properly align content after XTD buttons#10970
dgrammatiko wants to merge 2 commits intojoomla:stagingfrom
dgrammatiko:clearfix

Conversation

@dgrammatiko
Copy link
Copy Markdown
Contributor

@dgrammatiko dgrammatiko commented Jun 29, 2016

Pull Request for Issue joomla-extensions/weblinks#223

Summary of Changes

Just adding a class clearfix in the container div of the XTD-buttons

Testing Instructions

Apply patch and then test joomla-extensions/weblinks#223

@yvesh
Copy link
Copy Markdown
Member

yvesh commented Jun 29, 2016

I have tested this item 🔴 unsuccessfully on 74c18ea

Not working for me. The div (editor-xtd-buttons) you added the clearfix has the pull-left. (Wrong level for clearfix)

When you want to fix the issue with clearfix, you have to add it to the parent div before.. (not in that file and from JForm so not really possible)

<div class="controls clearfix">
..

would work.

screenshot 2016-06-29 22 29 57


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10970.

@joomla-cms-bot
Copy link
Copy Markdown

This PR has received new commits.

CC: @yvesh


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10970.

@dgrammatiko
Copy link
Copy Markdown
Contributor Author

@yvesh you're right that's not the correct place

@dgrammatiko dgrammatiko deleted the clearfix branch June 29, 2016 20:37
@yvesh
Copy link
Copy Markdown
Member

yvesh commented Jun 29, 2016

@DGT41 Now it only would work with TinyMCE (where this issue is not showing up at all) :( We need also a solution for no editor, codemirror and every other editor.

Sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants