Skip to content

Add new version of the powered by image#10814

Merged
wilsonge merged 1 commit intojoomla:stagingfrom
wilsonge:image-fix
Jun 13, 2016
Merged

Add new version of the powered by image#10814
wilsonge merged 1 commit intojoomla:stagingfrom
wilsonge:image-fix

Conversation

@wilsonge
Copy link
Copy Markdown
Contributor

This is a request from the marketing team to replace the powered by image with the latest version

@wilsonge wilsonge merged commit bc02edb into joomla:staging Jun 13, 2016
@wilsonge wilsonge deleted the image-fix branch June 13, 2016 22:19
@wilsonge wilsonge added this to the Joomla 3.6.0 milestone Jun 13, 2016
@brianteeman
Copy link
Copy Markdown
Contributor

I really wish you wouldn't commit your own PR especially without any tests. IF the image had identical dimensions then it might not have had any impact on an existing site but as this image has different dimensions it does have an impact on the layout of an existing web site

@PhilETaylor

This comment was marked as abuse.

@brianteeman
Copy link
Copy Markdown
Contributor

I said this would happen because the file was changed without a PR and
without any testing - sadly I was ignored

On 12 July 2016 at 21:47, Phil Taylor notifications@github.com wrote:

This file is not being distributed with the Joomla 3.6.0 update packages
also, so a Joomla 3.5.1 upgraded to Joomla 3.6.0 and a fresh Joomla 3.6.0
have different files... 👎


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#10814 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABPH8RBEyQFnp4Ti3xiSVxBEOFLYVj69ks5qU_1cgaJpZM4I0yn3
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants