Skip to content

Fix wrong quoting in PostgreSQL update files#10792

Merged
wilsonge merged 1 commit intojoomla:stagingfrom
mbabker:pgsql-quoting
Jun 15, 2016
Merged

Fix wrong quoting in PostgreSQL update files#10792
wilsonge merged 1 commit intojoomla:stagingfrom
mbabker:pgsql-quoting

Conversation

@mbabker
Copy link
Copy Markdown
Contributor

@mbabker mbabker commented Jun 11, 2016

Pull Request for Issue #10790

Summary of Changes

Incorrect quoting is used in the PostgreSQL update files resulting in the inability for all ~250 users of this database engine to upgrade to 3.6.

Testing Instructions

Review the modified files in accordance with the PostgreSQL specification.

@sovainfo
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on c21374d

Works!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10792.

@slibbe
Copy link
Copy Markdown

slibbe commented Jun 11, 2016

Hmm. If I hadn't looked any further I would have said that I tested this succesfully. Because that is what seems to be the case. Until I take a look at Extensions > Manage > Database. See attachments.
screen shot 2016-06-11 at 17 15 18
screen shot 2016-06-11 at 17 15 28


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10792.

@mbabker
Copy link
Copy Markdown
Contributor Author

mbabker commented Jun 11, 2016

Those are unrelated to this PR. The syntax errors causing the fatal error
from the screenshot in the original issue are fixed.

On Saturday, June 11, 2016, slibbe notifications@github.com wrote:

Hmm. If I hadn't looked any further I would have said that I tested this
succesfully. Because that is what seems to be the case. Until I take a look
at Extensions > Manage > Database. See attachments.
screen shot 2016-06-11 at 17 15 18
https://issues.joomla.org/uploads/1/5f4ab7300a9fe10e6d6b1abb90820179.jpg
screen shot 2016-06-11 at 17 15 28

https://issues.joomla.org/uploads/1/21c546fb6708063144d6013f5575e3bb.jpg

This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/10792
https://issues.joomla.org/tracker/joomla-cms/10792.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#10792 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAWfoUoB8U-XxcpUfAFcLEBufRVTyqnGks5qKzPRgaJpZM4Izkcf
.

@andrepereiradasilva
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on c21374d

on code review


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10792.

@sovainfo
Copy link
Copy Markdown
Contributor

@slibbe Tested the statements you reported with pgAdmin, they are correct. Suggest to verify logs/joomla_update.php to see what went wrong with your update!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10792.

@slibbe
Copy link
Copy Markdown

slibbe commented Jun 12, 2016

@sovainfo logs/joomla_update.php doesn't give a clue as to what went wrong.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10792.

@sovainfo
Copy link
Copy Markdown
Contributor

@slibbe Considering it is unrelated to this PR, suggest you post on forum.joomla.org (migration board). Include joomla_update.php.

@brianteeman
Copy link
Copy Markdown
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10792.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 13, 2016
@brianteeman brianteeman added this to the Joomla 3.6.0 milestone Jun 13, 2016
@wilsonge wilsonge merged commit b24cc05 into joomla:staging Jun 15, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 15, 2016
@wilsonge wilsonge added RTC This Pull Request is Ready To Commit and removed Release Blocker labels Jun 15, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants