Skip to content

Fix#10777. Placeholder not showing if zero(0) value in hint#10782

Merged
wilsonge merged 9 commits intostagingfrom
unknown repository
Jun 15, 2016
Merged

Fix#10777. Placeholder not showing if zero(0) value in hint#10782
wilsonge merged 9 commits intostagingfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Jun 10, 2016 •
edited by joomla-cms-bot
Loading

Pull Request for Issue #10777

Testing Instructions

Open e.g. /administrator/components/com_content/models/forms/article.xml and add following xml block inside attribs FIELDS and there inside basic FIELDSET.

<field name="examplecalendar" type="calendar"
label="examplecalendar" format="%Y-%m-%d %H:%M:%S" hint="0" />

<field name="examplecolor" type="color"
label="examplecolor" hint="0" />

<field name="exampleemail" type="email"
label="exampleemail" hint="0" />

<field name="examplenumber" type="number"
label="examplenumber" hint="0" />

<field name="examplepassword" type="password"
label="examplepassword" hint="0" />

<field name="exampletel" type="tel"
label="exampletel" hint="0" />

<field name="exampletext" type="text"
label="exampletext" hint="0" />

<field name="exampletextarea" type="textarea"
label="exampletextarea" hint="0" />

<field name="exampleurl" type="url"
label="exampleurl" hint="0" />

Go to backend. Open an article in edit view. Click tab options.
None of the fields has a 0 as placeholder text (hint="0").

Apply patch.

Try again.

dings

@ghost ghost mentioned this pull request Jun 10, 2016
Closed
@ghost ghost changed the title Fix#10777 (calendar). Placeholder not showing if zero(0) value in hint Fix#10777. Placeholder not showing if zero(0) value in hint Jun 10, 2016
@Globulopolis
Copy link
Copy Markdown

Globulopolis commented Jun 10, 2016

I have tested this item ✅ successfully on 1d7c775

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10782.

1 similar comment
@infograf768
Copy link
Copy Markdown
Member

infograf768 commented Jun 10, 2016

I have tested this item ✅ successfully on 1d7c775

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10782.

@infograf768
Copy link
Copy Markdown
Member

infograf768 commented Jun 10, 2016

rtc. thanks

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10782.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 10, 2016
@wilsonge wilsonge merged commit b2967c6 into joomla:staging Jun 15, 2016
@wilsonge wilsonge added this to the Joomla 3.6.0 milestone Jun 15, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Joomla 3.6.0

Development

Successfully merging this pull request may close these issues.

5 participants

@Globulopolis @infograf768 @wilsonge @joomla-cms-bot @bertmert