Skip to content

[com_config] add js message titles#10768

Merged
wilsonge merged 1 commit intojoomla:stagingfrom
andrepereiradasilva:config-add-js-message-titles
Jun 15, 2016
Merged

[com_config] add js message titles#10768
wilsonge merged 1 commit intojoomla:stagingfrom
andrepereiradasilva:config-add-js-message-titles

Conversation

@andrepereiradasilva
Copy link
Copy Markdown
Contributor

@andrepereiradasilva andrepereiradasilva commented Jun 9, 2016

Summary of Changes

This simple PR adds the js message titles in com_config (application and component view).

Testing Instructions

  1. Use latest staging
  2. Go to Configuration and send a test mail (or any behaviour that returns a js message - ex: permissions). Result: JS message WITHOUT the title.
    image
  3. Apply patch
  4. Repeat step 1. (remember to clear browser cache in config page). Result: JS message WITH the title.
    image

This should work for all message, notice, warning and error messages in com_config and component config.

@brianteeman
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 6d461c2


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10768.

@Ruchiranga
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 6d461c2

before

after


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10768.

@Ruchiranga
Copy link
Copy Markdown
Contributor

screen shot 2016-06-10 at 11 30 50
screen shot 2016-06-10 at 11 30 49


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10768.

@brianteeman
Copy link
Copy Markdown
Contributor

Rtc


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10768.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 10, 2016
@wilsonge wilsonge merged commit 3226027 into joomla:staging Jun 15, 2016
@wilsonge wilsonge added this to the Joomla 3.6.0 milestone Jun 15, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 15, 2016
@andrepereiradasilva andrepereiradasilva deleted the config-add-js-message-titles branch June 15, 2016 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants