Skip to content

New Plugin Event#10751

Merged
wilsonge merged 11 commits intojoomla:stagingfrom
wilsonge:jquery-upgrade
Jun 8, 2016
Merged

New Plugin Event#10751
wilsonge merged 11 commits intojoomla:stagingfrom
wilsonge:jquery-upgrade

Conversation

@wilsonge
Copy link
Copy Markdown
Contributor

@wilsonge wilsonge commented Jun 7, 2016 •
edited by brianteeman
Loading

Pull Request for Issue #10351

Summary of Changes

This succeeds @rdeutz 's PR at #10351 - it adds a generic on before validation event to allow manipulation of data to validate including the com_users PR that he mentioned earlier

Testing Instructions

Ensure there are no PHP errors in any core components

@wilsonge wilsonge mentioned this pull request Jun 7, 2016
Closed
zero-24
zero-24 reviewed Jun 8, 2016
View reviewed changes
libraries/legacy/model/admin.php Outdated
'save' => 'content',
'change_state' => 'content'
'change_state' => 'content',
'validate' => 'content'
Copy link
Copy Markdown
Contributor

@zero-24 zero-24 Jun 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we habe a , here too?

@wilsonge
Copy link
Copy Markdown
Contributor Author

wilsonge commented Jun 8, 2016

@zero-24 fixed

@wilsonge wilsonge added this to the Joomla 3.6.0 milestone Jun 8, 2016
@zero-24
Copy link
Copy Markdown
Contributor

zero-24 commented Jun 8, 2016

Thanks i have just noticed that there is a issue with the tests?!

There were 6 errors:
1) JModelFormTest::testValidateReturnsFalseOnJformException
JDatabaseExceptionExecuting: No database selected SQL=SELECT id, rules
FROM `#__viewlevels`
/home/travis/build/joomla/joomla-cms/libraries/joomla/database/driver/mysqli.php:660
/home/travis/build/joomla/joomla-cms/libraries/joomla/database/driver.php:1494
/home/travis/build/joomla/joomla-cms/libraries/joomla/access/access.php:935
/home/travis/build/joomla/joomla-cms/libraries/joomla/user/user.php:453
/home/travis/build/joomla/joomla-cms/libraries/cms/plugin/helper.php:296
/home/travis/build/joomla/joomla-cms/libraries/cms/plugin/helper.php:163
/home/travis/build/joomla/joomla-cms/libraries/legacy/model/form.php:333
/home/travis/build/joomla/joomla-cms/tests/unit/suites/libraries/legacy/model/JModelFormTest.php:57
2) JModelFormTest::testValidateReturnsFalseOnJformFalse
JDatabaseExceptionExecuting: No database selected SQL=SELECT id, rules
FROM `#__viewlevels`
/home/travis/build/joomla/joomla-cms/libraries/joomla/database/driver/mysqli.php:660
/home/travis/build/joomla/joomla-cms/libraries/joomla/database/driver.php:1494
/home/travis/build/joomla/joomla-cms/libraries/joomla/access/access.php:935
/home/travis/build/joomla/joomla-cms/libraries/joomla/user/user.php:453
/home/travis/build/joomla/joomla-cms/libraries/cms/plugin/helper.php:296
/home/travis/build/joomla/joomla-cms/libraries/cms/plugin/helper.php:163
/home/travis/build/joomla/joomla-cms/libraries/legacy/model/form.php:333
/home/travis/build/joomla/joomla-cms/tests/unit/suites/libraries/legacy/model/JModelFormTest.php:101
3) JModelFormTest::testValidateModifiesTagsArray with data set #0 (array('1'), array('1'))
JDatabaseExceptionExecuting: No database selected SQL=SELECT id, rules
FROM `#__viewlevels`
/home/travis/build/joomla/joomla-cms/libraries/joomla/database/driver/mysqli.php:660
/home/travis/build/joomla/joomla-cms/libraries/joomla/database/driver.php:1494
/home/travis/build/joomla/joomla-cms/libraries/joomla/access/access.php:935
/home/travis/build/joomla/joomla-cms/libraries/joomla/user/user.php:453
/home/travis/build/joomla/joomla-cms/libraries/cms/plugin/helper.php:296
/home/travis/build/joomla/joomla-cms/libraries/cms/plugin/helper.php:163
/home/travis/build/joomla/joomla-cms/libraries/legacy/model/form.php:333
/home/travis/build/joomla/joomla-cms/tests/unit/suites/libraries/legacy/model/JModelFormTest.php:150
4) JModelFormTest::testValidateModifiesTagsArray with data set #1 (array(array('1')), array(array('1'), '1'))
JDatabaseExceptionExecuting: No database selected SQL=SELECT id, rules
FROM `#__viewlevels`
/home/travis/build/joomla/joomla-cms/libraries/joomla/database/driver/mysqli.php:660
/home/travis/build/joomla/joomla-cms/libraries/joomla/database/driver.php:1494
/home/travis/build/joomla/joomla-cms/libraries/joomla/access/access.php:935
/home/travis/build/joomla/joomla-cms/libraries/joomla/user/user.php:453
/home/travis/build/joomla/joomla-cms/libraries/cms/plugin/helper.php:296
/home/travis/build/joomla/joomla-cms/libraries/cms/plugin/helper.php:163
/home/travis/build/joomla/joomla-cms/libraries/legacy/model/form.php:333
/home/travis/build/joomla/joomla-cms/tests/unit/suites/libraries/legacy/model/JModelFormTest.php:150
5) JModelFormTest::testValidateModifiesTagsArray with data set #2 (array('1', array('2')), array('1', array('2')))
JDatabaseExceptionExecuting: No database selected SQL=SELECT id, rules
FROM `#__viewlevels`
/home/travis/build/joomla/joomla-cms/libraries/joomla/database/driver/mysqli.php:660
/home/travis/build/joomla/joomla-cms/libraries/joomla/database/driver.php:1494
/home/travis/build/joomla/joomla-cms/libraries/joomla/access/access.php:935
/home/travis/build/joomla/joomla-cms/libraries/joomla/user/user.php:453
/home/travis/build/joomla/joomla-cms/libraries/cms/plugin/helper.php:296
/home/travis/build/joomla/joomla-cms/libraries/cms/plugin/helper.php:163
/home/travis/build/joomla/joomla-cms/libraries/legacy/model/form.php:333
/home/travis/build/joomla/joomla-cms/tests/unit/suites/libraries/legacy/model/JModelFormTest.php:150
6) JModelFormTest::testValidatePassesDataAndGroupToJform
JDatabaseExceptionExecuting: No database selected SQL=SELECT id, rules
FROM `#__viewlevels`
/home/travis/build/joomla/joomla-cms/libraries/joomla/database/driver/mysqli.php:660
/home/travis/build/joomla/joomla-cms/libraries/joomla/database/driver.php:1494
/home/travis/build/joomla/joomla-cms/libraries/joomla/access/access.php:935
/home/travis/build/joomla/joomla-cms/libraries/joomla/user/user.php:453
/home/travis/build/joomla/joomla-cms/libraries/cms/plugin/helper.php:296
/home/travis/build/joomla/joomla-cms/libraries/cms/plugin/helper.php:163
/home/travis/build/joomla/joomla-cms/libraries/legacy/model/form.php:333
/home/travis/build/joomla/joomla-cms/tests/unit/suites/libraries/legacy/model/JModelFormTest.php:186

@rdeutz
Copy link
Copy Markdown
Contributor

rdeutz commented Jun 8, 2016

I have tested this item ✅ successfully on 162e40f

works as expected (with the simplify user plugin) when also applying #10350

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10751.

@joomla-cms-bot
Copy link
Copy Markdown

joomla-cms-bot commented Jun 8, 2016

This PR has received new commits.

CC: @rdeutz

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10751.

@joomla-cms-bot
Copy link
Copy Markdown

joomla-cms-bot commented Jun 8, 2016

This PR has received new commits.

CC: @rdeutz

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10751.

@wilsonge wilsonge merged commit e2c3b29 into joomla:staging Jun 8, 2016
@wilsonge wilsonge deleted the jquery-upgrade branch June 8, 2016 21:51
@Bakual Bakual mentioned this pull request Jan 18, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Unit/System Tests

Projects

None yet

Milestone

Joomla 3.6.0

Development

Successfully merging this pull request may close these issues.

4 participants

@wilsonge @zero-24 @rdeutz @joomla-cms-bot