Render the sidebar when it is not empty#10720
Conversation
|
How about just always render it and avoid conditionals like https://github.com/Digital-Peak/joomla-cms/blob/98aca2d283ae91c39414207fbc477b46b130e11b/administrator/components/com_modules/views/modules/tmpl/default.php#L29-L36 in the layouts. |
|
I tested it and it showed then the sidebar with an empty list. |
|
|
|
Means? |
|
Just as you pointed out, the sidebar here can be empty. On most other views that have the sidebar conditional, it's usually not unless someone used a malicious plugin to remove the component's defined sidebar so that conditional is just bloated logic. |
|
I have tested this item ✅ successfully on 98aca2d This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10720. |
|
I have tested this item ✅ successfully on 98aca2d This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10720. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10720. |
Summary of Changes
When a plugin adds some sidebar entries for com_modules, then render it.
Testing Instructions
Expected result
You should see on the left side a list of links (Modules, Fields, Field Categories). After DPFields is uninstalled, the view Extensions -> Modules should be shown without a sidebar.
Actual Result
The sidebar is not shown.