Skip to content

Update Tinymce editor#10719

Merged
wilsonge merged 2 commits intojoomla:stagingfrom
brianteeman:tinymce
Jun 15, 2016
Merged

Update Tinymce editor#10719
wilsonge merged 2 commits intojoomla:stagingfrom
brianteeman:tinymce

Conversation

@brianteeman
Copy link
Copy Markdown
Contributor

@brianteeman brianteeman commented Jun 3, 2016

Update to latest release of tinymce 4.3.12

Summary of Changes

Version 4.3.12 (2016-05-10)
Fixed bug where focus calls couldn't be made inside the editors PostRender event handler.
Fixed bug where some translations wouldn't work as expected due to a bug in editor.translate.
Fixed bug where the node change event could fire with a node out side the root of the editor.
Fixed bug where Chrome wouldn't properly present the keyboard paste clipboard details when paste was clicked.
Fixed bug where merged cells in tables couldn't be selected from right to left.
Fixed bug where insert row wouldn't properly update a merged cells rowspan property.
Fixed bug where the color input boxes preview field wasn't properly set on initialization.
Fixed bug where IME composition inside table cells wouldn't work as expected on IE 11.
Fixed so all shadow dom support is under and experimental flag due to flaky browser support.#### Testing Instructions

@smitshah81
Copy link
Copy Markdown

Hi ,
Can you please guide me how can I test this issue?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10719.

@brianteeman
Copy link
Copy Markdown
Contributor Author

Apply the pull request and check that the editor still works as you expect. For extra credit create a table and merge some cells and then ake sure you can select them


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10719.

@dgrammatiko
Copy link
Copy Markdown
Contributor

@smitshah81 try to d/l https://github.com/brianteeman/joomla-cms/archive/tinymce.zip and then install joomla as usual. then check if tinymce still works. (that's in case com patch tester is not working and you are not familiar with git)

@ghost
Copy link
Copy Markdown

ghost commented Jun 10, 2016

I have tested this item ✅ successfully on 1ff9e49


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10719.

@smitshah81
Copy link
Copy Markdown

Hi I have checked this issue and i found that it is not working in firefox 47.0 OS : Ubuntu 12.04,However it is working in chromium browser.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10719.

@brianteeman
Copy link
Copy Markdown
Contributor Author

what is not working - thats a very broad statement

On 11 June 2016 at 13:55, smit shah notifications@github.com wrote:

Hi I have checked this issue and i found that it is not working in firefox

47.0 OS : Ubuntu 12.04,However it is working in chromium browser.

This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/10719
https://issues.joomla.org/tracker/joomla-cms/10719.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#10719 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ABPH8SktlAAUXBeFlYrwvcWmj_JrOc6eks5qKrBIgaJpZM4ItfzR
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

@smitshah81
Copy link
Copy Markdown

I had tried to create table and merge cell and select them but I was not able to select them.But I can do same in chromium browser

@brianteeman
Copy link
Copy Markdown
Contributor Author

brianteeman commented Jun 11, 2016 via email

@infograf768
Copy link
Copy Markdown
Member

I have tested this item ✅ successfully on 1ff9e49


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10719.

@infograf768
Copy link
Copy Markdown
Member

RTC. Thanks.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10719.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 13, 2016
@wilsonge wilsonge merged commit fba804a into joomla:staging Jun 15, 2016
@wilsonge wilsonge added this to the Joomla 3.6.0 milestone Jun 15, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 15, 2016
@brianteeman brianteeman deleted the tinymce branch July 22, 2016 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants