[plg_search_tags] Search results now don't include unpublished, archived or trashed tags#10713
[plg_search_tags] Search results now don't include unpublished, archived or trashed tags#10713wilsonge merged 3 commits intojoomla:stagingfrom EmilMassey:tags_plugin
Conversation
Sync with joomla/joomla-cms
|
Looking at code, I think you should separate the query for published, and leave alone the code with |
|
I have tested this item ✅ successfully on c0b829b This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10713. |
|
I have tested this item ✅ successfully on c0b829b $query->where($db->qn('a.published') . ' = 1');Thanks for fixes. This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10713. |
|
rtc This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10713. |
|
@brianteeman Please remove RTC, see comments by @infograf768 and @gunjanpatel . |
|
Done |
|
Back to pending This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10713. |
|
Please update your PR |
|
This PR has received new commits. CC: @gunjanpatel, @hardiktasol This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10713. |
|
I have tested this item ✅ successfully on db7e77e This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10713. |
|
As the previously tested PR has been updated and confirmed by @gunjanpatel I am setting this back to RTC This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10713. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10713. |
|
Thank you @infograf768, @gunjanpatel for your suggestions. |
|
Merged :) Thanks very much! |
Pull Request for Issue #10712 .
Summary of Changes
Select only published tags from the database by adding
$query->where('a.published = 1');.Testing Instructions