[com_modules] positions view: client_id selector naming#10695
Merged
wilsonge merged 1 commit intojoomla:stagingfrom Jun 15, 2016
Merged
[com_modules] positions view: client_id selector naming#10695wilsonge merged 1 commit intojoomla:stagingfrom
wilsonge merged 1 commit intojoomla:stagingfrom
Conversation
Contributor
|
This modal is used in Hathor ;-) This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10695. |
Contributor
Author
|
lol always hathor ... |
Contributor
|
I have tested this item ✅ successfully on 62fb58f This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10695. |
Contributor
|
I've tested this successfully This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10695. |
Contributor
|
I have tested this item ✅ successfully on 62fb58f This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10695. |
Contributor
|
Rtc This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10695. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
The
client_idseletor is namedclient_id, notfilter.client_id.. This was uniformized in 3.6.0 across all modules, cache, templates and languages views (the ones that have the client_id selector).One view remain: the positions view in com_modules. I think this view is unused in the core but still should be changed. So, this PR changes it.
Testing Instructions
/administrator/index.php?option=com_modules&view=positions&layout=modal&tmpl=component&client_id=0(should show the site template positions)
/administrator/index.php?option=com_modules&view=positions&layout=modal&tmpl=component&client_id=1(should show the admin template positions)
/administrator/index.php?option=com_modules&view=positions&layout=modal&tmpl=component(should show the admin template positions, since it was the last one used)