[JDocument render] Use real tabs for rendering tabs, not two spaces ...#10642
Merged
wilsonge merged 3 commits intojoomla:stagingfrom Jun 15, 2016
Merged
[JDocument render] Use real tabs for rendering tabs, not two spaces ...#10642wilsonge merged 3 commits intojoomla:stagingfrom
wilsonge merged 3 commits intojoomla:stagingfrom
Conversation
Contributor
|
I have tested this item ✅ successfully on 059e3dd This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10642. |
|
This PR has received new commits. CC: @alikon This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10642. |
|
This PR has received new commits. CC: @alikon This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10642. |
Contributor
Author
|
@alikon please mark as success again. i made a mistake. is exactly how it was when you tested. |
Contributor
|
i was starting search for PHP_TAB , aborting now ;) |
Contributor
|
I have tested this item ✅ successfully on 0bd1a0c This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10642. |
Contributor
Author
|
ehheh yeah it was in bump.php (https://github.com/joomla/joomla-cms/blob/staging/build/bump.php#L36) i forgot that i defined as a constant there :) |
|
I have tested this item ✅ successfully on 0bd1a0c This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10642. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10642. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Simple PR to use tabs for tabs instead of two spaces when rendering.
Note: don't know why the two spaces were there in the first place (since 6 Aug 2006)
Testing Instructions
Code review, or:
<script...starts after two spaces.<script...starts after one tab.