Skip to content

[plg_user_joomla]Code style#10510

Merged
rdeutz merged 2 commits intojoomla:stagingfrom
wojsmol:plg_user_joomla-cs
May 16, 2016
Merged

[plg_user_joomla]Code style#10510
rdeutz merged 2 commits intojoomla:stagingfrom
wojsmol:plg_user_joomla-cs

Conversation

@wojsmol
Copy link
Copy Markdown
Contributor

@wojsmol wojsmol commented May 16, 2016

Summary of Changes

Code style changes for plg_user_joomla

Testing Instructions

code review

@brianteeman
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on 054056e


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10510.

class="btn-group btn-group-yesno"
default="1"
label="PLG_USER_JOOMLA_FIELD_MAILTOUSER_LABEL"
class="btn-group btn-group-yesno"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the order should be name, type, label, description

@joomla-cms-bot
Copy link
Copy Markdown

This PR has received new commits.

CC: @brianteeman


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10510.

@andrepereiradasilva
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on e82da44

on code review


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10510.

@brianteeman
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on e82da44


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10510.

@brianteeman
Copy link
Copy Markdown
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10510.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 16, 2016
@brianteeman brianteeman added this to the Joomla 3.6.0 milestone May 16, 2016
@rdeutz rdeutz merged commit ede5014 into joomla:staging May 16, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 16, 2016
@wojsmol wojsmol deleted the plg_user_joomla-cs branch May 16, 2016 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants