[plg_system_updatenotification]Code style#10506
Merged
rdeutz merged 2 commits intojoomla:stagingfrom May 16, 2016
Merged
Conversation
Contributor
|
I have tested this item ✅ successfully on ba24f61 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10506. |
| $fromName = $jConfig->get('fromname'); | ||
|
|
||
| $substitutions = array( | ||
| $substitutions = array( |
Contributor
There was a problem hiding this comment.
why the space?
Contributor
Author
There was a problem hiding this comment.
align with lines below
Contributor
There was a problem hiding this comment.
what lines below?
Contributor
Author
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
i would understand aligning with lines above, not with below.
|
This PR has received new commits. CC: @brianteeman This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10506. |
Contributor
|
I have tested this item ✅ successfully on 5cc7c08 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10506. |
Contributor
|
I have tested this item ✅ successfully on 5cc7c08 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10506. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10506. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Code style changes for plg_system_updatenotification
Testing Instructions
code review