Skip to content

[plg_search_newsfeeds]Code style#10494

Merged
rdeutz merged 4 commits intojoomla:stagingfrom
wojsmol:plg_search_newsfeeds-cs
May 16, 2016
Merged

[plg_search_newsfeeds]Code style#10494
rdeutz merged 4 commits intojoomla:stagingfrom
wojsmol:plg_search_newsfeeds-cs

Conversation

@wojsmol
Copy link
Copy Markdown
Contributor

@wojsmol wojsmol commented May 15, 2016

Summary of Changes

Code style changes for plg_search_newsfeeds

Testing Instructions

code review

@brianteeman
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on fa521a9


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10494.

@cyrez
Copy link
Copy Markdown
Contributor

cyrez commented May 15, 2016

@wojsmol maybe removal of empty line after closing fielset?

@joomla-cms-bot
Copy link
Copy Markdown

This PR has received new commits.

CC: @brianteeman


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10494.

@wojsmol
Copy link
Copy Markdown
Contributor Author

wojsmol commented May 15, 2016

@JoomliC done

@brianteeman
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on e6f8136


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10494.

@andrepereiradasilva
Copy link
Copy Markdown
Contributor

I have tested this item ✅ successfully on e6f8136

on code review


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10494.

@brianteeman
Copy link
Copy Markdown
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10494.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 16, 2016
@brianteeman brianteeman added this to the Joomla 3.6.0 milestone May 16, 2016
@cyrez
Copy link
Copy Markdown
Contributor

cyrez commented May 16, 2016

@wojsmol thanks! 👍

@rdeutz rdeutz merged commit 5d585d9 into joomla:staging May 16, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 16, 2016
@wojsmol wojsmol deleted the plg_search_newsfeeds-cs branch May 16, 2016 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants